Giter Site home page Giter Site logo

issue with ]c and [c mapping about vim-signify HOT 6 CLOSED

mhinz avatar mhinz commented on May 24, 2024
issue with ]c and [c mapping

from vim-signify.

Comments (6)

mhinz avatar mhinz commented on May 24, 2024

Well, I included it because users asked for it, but I can see the problem.

I see 2 possible solutions:

  1. Like you said: remap to ]g and [g instead.

  2. I could add another BufEnter hook which checks if &diff is set. People just would have to use ':diffsplit %' instead of just ':diffsplit', so the buffer actually gets reloaded.

If I can't come up with a better idea until tonight, I'll do #1.

from vim-signify.

zhaocai avatar zhaocai commented on May 24, 2024
  1. I could add another BufEnter hook which checks if &diff is set. People just would have to use ':diffsplit %' instead of just ':diffsplit', so the buffer actually gets reloaded.

I prefer this one, and I suggest to only map ]c,[c for signify when it is appropriate - only in a cvs repo, signify is toggled, and &diff == 0.

I hope you could also look at https://github.com/spiiph/vim-space to see if you can make this mapping compatible with motion repeating.

from vim-signify.

mhinz avatar mhinz commented on May 24, 2024

Does one actually want Sy to be enabled at all, if &diff == 1?

Performance-wise it would be the best to map while starting Sy and unmap while stopping Sy. So if the user switches to diff mode, he'd just have to toggle Sy off.

So I could avoid adding another BufEnter hook. And it would be somewhat futureproof.

from vim-signify.

zhaocai avatar zhaocai commented on May 24, 2024

So I could avoid adding another BufEnter hook. And it would be somewhat futureproof.
turn Sy off in diff mode is good enough for me.

from vim-signify.

mhinz avatar mhinz commented on May 24, 2024

Okay, I'm making some more refactoring and commit this evening or tomorrow.

from vim-signify.

mhinz avatar mhinz commented on May 24, 2024

BTW, spiiph used to be a regular on IRC, but got a bit inactive in the last time. I'll look into space.vim.

from vim-signify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.