'SignifyChangeDelete' not working correctly for vim built without netbeans integration

[mhinz]

'SignifyChangeDelete' not working correctly for vim built without netbeans integration

[mhinz]

Good catch, good report. Thanks for the feedback! I'll dig into it.

[willthefrog]

You are welcome. Nice plugin btw 👍

[mhinz]

Unfortunately one line won't be enough to fix this, because the problem is more complex.

Image this file:

this is line 1
this is line 2
this is line 3
this is line 4

When you change line 2 and remove line 3 you get !_ on line 2 which is correct.

But when you remove line 2 and change (the new) line 2 you should get _1 on line 1 and ! on line 2. Instead you get !_ on line 2.

That's because the diff is basically the same for both cases. I'll try to come up with a proper solution.

[willthefrog]

This seems to be separate issue and should happen regardless of netbeans integration.

A simple test confirmed that: same things happens in Arch version of vim, only it shows a ! instead of !_ on line 2.

Anyway, this is confusing. Hope you can find a way to cover all those cases.

[mhinz]

This commit should work for you. it adds a lot of comments, but basically I just changed 2 small things to get the wanted behaviour.

[willthefrog]

Just tested, it's working. Thanks a lot 👍

[mhinz]

Splendid!