If overwrite is enabled for unarchive, and the file being overwritten is a symlink, then it tries to follow the symlink, rather than replace it

[deitch]

If overwrite is enabled for unarchive, and the file being overwritten is a symlink, then it tries to follow the symlink, rather than replace it

[deitch]

Actually, how do I test? v4.Tar doesn't have OverwriteExisting.

[deitch]

Nope, no need for fs.FS. I just like the (albeit limited) standard interface. I needed a full-purpose one, implemented it, but that doesn't matter here.

Thanks for explaining!

[deitch]

It is in syft.

FYI, I also have some tar management in go-apk, under here. I wouldn't mind repeating it.

[mholt]

Hi, thanks for the issue. I'm no longer supporting v3 though -- does this happen in v4?

[deitch]

That is a good question. Now that I have a sample, I can try it out. Reporting back soon.

[deitch]

Yeah, it does. I will update the issue. But the fix likely is not the same

[deitch]

Actually, one sec. I might have run the wrong thing. I will post back here shortly.

[mholt]

D'oh, I'm sorry -- v4 doesn't have OverwriteExisting because we changed how v4 does extractions. Archiver v4 doesn't actually do disk operations, it only does stream operations. So you call Extract() and then you open the files to write to disk, this resolves the issue since you have complete control over it. 💯

[deitch]

I am trying to wrap my head around that. So it is similar to fs.WalkDir(), where you provide it a handler, and then do what you want with it?

Come to think of it, does it actually implement fs.FS so that you could use fs.WalkDir() on it?

[mholt]

Yes, you can call archiver.FileSystem() to get a fs.FS which you can walk. The extract method is a little similar to walking, and indeed it does let you walk the archive -- it may be more efficient to use Extract though, unless you need fs.FS for something.

[mholt]

No problem. Just curious, what are you using archiver for?

Thanks for your detailed issue report btw, would love to see more like that.

[mholt]

Cool! We use syft with Caddy as part of our release workflow.