Output parameters can not be used to filter other DSs

[michael-e]

Output parameters can not be used to filter other DSs

[nilshoerrmann]

I'm not sure, I've fully understood this. Can you provide an example of what is stored and what should be stored? Why is the DS non-existent?

[michael-e]

The issue seems to be with the 2.2.x branch only.

In S 2.2.5, the Datasource name is always Storage. An output parameter name will be built using dashes, like so:

    <ds-storage-cart>
        <item handle="item1">item1</item>
    </ds-storage-cart>

Now add $ds-storage-cart to the filter of a second datasource, and the auto-generated dependency will be:

$this->_dependencies = array('$ds-storage-cart');

This dependency can not be resolved, because there is no datasource with this name.

Symphony 2.3.:

I don't have a full-blown 2.3 installation, but some quick tests show that probably the issue does not exist. If you have a parameter like this:

    <ds-myfunny-storage.cart>
        <item handle="item1">item1</item>
    </ds-myfunny-storage.cart>

and add this to a datasource filter, the dependency will be:

$this->_dependencies = array('$ds-myfunny-storage.cart');

which seems to be resolved correctly. (Can you confirm this?)

[nilshoerrmann]

This dependency can not be resolved, because there is no datasource with this name.

So this is a Symphony bug: Symphony doesn't take data sources provided by extensions into account.

which seems to be resolved correctly. (Can you confirm this?)

I'll check that.

[michael-e]

No, it's not a Symphony bug. It's caused by the naming of the parameter. In the 2.2 example, if you manually change the dependency to be:

$this->_dependencies = array('$ds-storage');

it works!

So I think that this is a flaw in the 2.2.x branch of our extension which can not be solved easily. We might simply add it to the README.

[nilshoerrmann]

But doesn't hat mean, that we have to change the 2.2.x data source to only return a single output parameter for all groups, see https://github.com/hananils/storage/blob/2.2.x/data-sources/data.storage.php#L48-L50?

if(is_array($groups)) {
    $output = array();
    foreach($groups as $name => $values) {
        array_push($output, array_keys((array)$values));
    }
    $param_pool['ds-' . $this->dsParamROOTELEMENT] = $output;
}

(Haven't tested that.)

[michael-e]

That wouldn't help for filtering, because we would mix the items of all groups in a single parameter.

[nilshoerrmann]

But wouldn't that have the same result as renaming your DS manually.
I may be slow today though …

[michael-e]

You can not rename the Storage DS in the 2.2.x branch. But you can manually change the dependency in your second DS, so the the Storage DS will be executed first. Then filtering works with the parameters provided.

[nilshoerrmann]

Okay. In this case, I don't see a solution as it seems to be a system restriction that there can only be one output parameter per data source in 2.2.5.

[michael-e]

Yep, this is the reason that params with dots are not allowed in S 2.2, so we had to use dashes.

So we simply add this to the README, right?

[nilshoerrmann]

Seems to be the best option.
Everything else I can think of is hacking Symphony 2.2 and that doesn't make much sense.

[michael-e]

I will do it.

[michael-e]

Fixed by f2a7d93.

[michael-e]

I rebased the 2.2x branch and fixed a bug that I have introduced before. Your best bet is to delete your local version and clone the current repo.

I should always test my own stuff as well.
I should always test my own stuff as well.
I should always test my own stuff as well.
....