Colors

[michaeldfallen]

Colors

[jackmaney]

👍 I'm using a solarized dark color scheme, and I can only see the portion of my git-radar prompt that's within the parentheses.

[michaeldfallen]

I use the built in colours that are set by your terminal, so in theory it's due to your terminal having the same colour set for the background as the black colour.

hmm, I should probably change the git:( part to something other than the "bold black" colour and the branch name to reset instead of "bold white" (which in my molokai colour scheme is light grey.

[michaeldfallen]

Am I right in assuming you use: https://github.com/tomislav/osx-terminal.app-colors-solarized? I just installed it and found that it's put the darker colours (content tones, dark black, etc) in to the "bright" colour slots. I'll try to do up some colour changes that support it but most have the colours become lighter in the "bright" slots so it might not marry up quite right.

[apas]

@michaeldfallen yes, I use Solarized Dark from the official iTerm package.

[jackmaney]

@michaeldfallen Actually, I'm using https://github.com/altercation/solarized/tree/master/iterm2-colors-solarized It's unclear if there's a difference (other than one of them appearing to use base 64 encoding (I think?) to encode colors vs specifying RGB).

[michaeldfallen]

I'll add an alternative color scheme controlled by args. Might take a while to get it looking nice though.

[jackmaney]

Would it be easier to have configurable colors via, say, ~/.git-radarrc (or similar)? Then you could specify semantic colors, eg:

export GIT_RADAR_BRANCH_NAME_COLOR="\[033[36m\]" # cyan
export GIT_RADAR_UNTRACKED_COLOR="\e[97m" #white
# etc

[jedsmith]

+1 on configurable colors, particularly for folks who are various types of color blind.

[michaeldfallen]

@jedsmith the colours are your terminals colours. So if you are colour blind it should pick up the colours you've chosen for your terminal, which I would assume are colourblind safe? Are there terminal themes that are colourblind safe? http://ciembor.github.io/4bit/ is quite useful for creating a theme so could help.

[michaeldfallen]

@jackmaney yeah you're right, having each part that can be coloured as a configurable value, either through args / env / rc file is probably the best way to go 👍

[Droogans]

You're using green and red for staged/unstaged changes, which isn't colorblind friendly at all. I've defined these colors in my .gitconfig to be cyan and red, respectively. Is there a reason you're not pulling these preferences from a user's .gitconfig?

[michaeldfallen]

@Droogans No, I'm using the colour that your terminal claims is green. If you're colourblind you need to redefine the colours you can't see to something else that you can see. It'll still be considered green and git-radar will still use it, but you'll be able to see it.

So while you have set those colours in .gitconfig you need to set them in your terminal so that any process that asks for green will get the colour you can see.

[michaeldfallen]

I believe that #39 has solved this for you.