Giter Site home page Giter Site logo

Comments (4)

michaellzc avatar michaellzc commented on June 20, 2024

Please see my response at #37 (comment)

from better-opn.

thany avatar thany commented on June 20, 2024

This issue is not specific to Storybook, better-opn - if I read the source code correctly - literally opens powershell.exe to open a browser tab. Just don't? 🤷🏻‍♂️ You don't need powershell just to open a browser tab.

If I type on the command prompt:

start https://duckduckgo.com

It will open a tab in my favourite/default browser to go there. Job done. This doesn't need X-many different approaches on Windows.

This will solve similar problems in other packages as well. Not just Storybook.

(In hindsight, I shouldn't have mentioned Storybook maybe. I imagine you took it as reporting a problem here, that existed there, but this problem is NOT specific to Storybook, just to get that clear as day)

from better-opn.

michaellzc avatar michaellzc commented on June 20, 2024

better-opn is created to do one thing and one thing only (that solved my pain point when working on some side projects with GatsbyJS gatsbyjs/gatsby#6550), reuse browser tab on macOS otherwise fallback to the upstream open package. I do not intent or have the bandwidth to maintain a fork of open and implement new features.

Therefore, what you're proposing is out of the scope this project. Would you kindly move the discussion into the upstream open project instead?

from better-opn.

thany avatar thany commented on June 20, 2024

So you're saying on Windows and Linux, better-opn simply doesn't need to exist? That does confirm my finding that I've never seen it reusing any browser tab.

This might be important to know for users of this package.

But even so, I do like to know: why bother with powershell? If this is a macOS-minded package, why do you bother with a Windows feature that isn't even needed?

from better-opn.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.