Comments (8)
How are you gentlemen!
It suffices to look at line 616 of passports.m
(appropriately enough the Number of the Beast in the oldest preserved manuscript of the Apocalypse of John) and replace
if #partition_tups ne 0 then
check := &and[ part in cycstrs : part in partition_tups ];
Append(~checks, check);
end if;
if #checks eq 0 then
return true;
end if;
return &and(checks);
by
if #partition_tups ne 0 then
check := &and[ cycstr in partition_tups : cycstr in cycstrs ];
if check and #partition_tups eq 3 then
check := Sort(cycstrs) eq Sort(partition_tups);
end if;
Append(~checks, check);
end if;
if #checks eq 0 then
return true;
end if;
return &and(checks);
Not all bells and whistles got tested at the time.
Kind regards,
Jeroen
from belyi.
Yes that is unfortunate but noted. There is another repository where @SamSchiavone is repackaging the triangle code. If we deal with it there I will close this, but otherwise leave it open. Thanks!
from belyi.
Oh, awesome! Is Sam's a fork of this one, or something separate?
from belyi.
I'm not sure. It probably started as something close to this, but the goal is to update for use with a more current Magma version. It is a private repository for the moment, but hopefully we can make some progress over the holiday and release a self-contained Magma package.
Probably makes more sense for the current version to live in Sam's github anyways.
Were you looking for this functionality for anything specific? I think the priority right now is to just get something compatible with current Magma. Revisiting the passport code could also be bumped up to a higher priority.
from belyi.
Hey John,
I've worked a bit on the new triangle and Belyi map code, but it's still in its early stages. I've made a new GrpPSL2Tri class and I'm currently working on the triangle functionality. I'm planning to make a separate Belyi map class (and maybe a couple others) to try to split up the attributes we tacked on to GrpPSL2 in some logical way. I'll send you an invite to the repo.
from belyi.
@SamSchiavone did you fix this as part of your rewrite, or should I submit a pull request? (Don't want to cause conflicts!)
from belyi.
No, I don't think I've gotten this far in the rewrite yet, so feel free to submit a PR.
from belyi.
Changed this in "passports_jeroen_2018.m", PR #2. Seems to work now.
from belyi.
Related Issues (11)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from belyi.