Giter Site home page Giter Site logo

Comments (13)

MichaelSolati avatar MichaelSolati commented on May 19, 2024 1

Hey @MarcL, try replacing geofirestore with npm i MichaelSolati/geofirestore. I think I pinned down the issue (THINK), and pushed up a tweak for this. But I'd like to make sure it works for you first. (I tried running the get like 50 times after the fix and had no issues)

from geofirestore-js.

MichaelSolati avatar MichaelSolati commented on May 19, 2024

@MarcL can I get a picture of your database? Geofirestore's geohashes are all in lowercase, so that may be an issue. But still seeing the data would be helpful. (Not really sure if this is it, I honestly doubt it, but a glimpse may still be able to help!)

from geofirestore-js.

MarcL avatar MarcL commented on May 19, 2024

Thanks @MichaelSolati. Here's an image of the data in my database:

screen shot 2018-09-17 at 09 05 31

This only has 6 documents in the collection and I've found that it even happens with just a couple.
All of the geohashes are lowercase but not sure if there's anything I need to do in the query.

from geofirestore-js.

MichaelSolati avatar MichaelSolati commented on May 19, 2024

Ughh, ok, so this is really odd (and painful), as the tests should catch this. As this may be a nuisance, would you mind making a sample repo as minimal as possible with it not working? (This would seriously help)

from geofirestore-js.

MarcL avatar MarcL commented on May 19, 2024

Hey @MichaelSolati. Thanks for investigating. I'll get this done for you today and get a simple failure case. Thanks.

from geofirestore-js.

MarcL avatar MarcL commented on May 19, 2024

Try this project @MichaelSolati. It should be a basic test and I've put instructions in the README. Thanks for your help.

https://github.com/MarcL/geofirestore-test

from geofirestore-js.

MarcL avatar MarcL commented on May 19, 2024

Thanks @MichaelSolati. I've just tried the version from this repo in the test project and seems to work as expected. Thanks!

from geofirestore-js.

MarcL avatar MarcL commented on May 19, 2024

@MichaelSolati - Is Firestore a lot slower than the realtime database? I'm just doing some test queries locally using the above fix and I'm seeing an average query time of ~2000 ms. I then do a similar test with the Firebase realtime database and geofire-js and I'm getting average query times with the same query of 400 ms. The data schema is a bit different to account for the advice on denormalisation for the realtime database, but I just wondered if there was anything obvious to speed up the Firestore queries. Thanks.

from geofirestore-js.

MichaelSolati avatar MichaelSolati commented on May 19, 2024

So I don't think I've explicitly seen anything saying that the RTDB is faster than Firestore, but I completely think that's true. The RTDB is advertised as "low-latency", while nothing is explicitly stated about Fitestore's speed...

Looking here they don't mention anything about speed under "Reliability and performance" as well as "Scalability."

So, IMHO, you'll get speed with the RTDB, you'll get a more powerful database and queryability with Firestore.

from geofirestore-js.

MarcL avatar MarcL commented on May 19, 2024

Thanks for the info. I wanted to use Firestore as I'd not used it before, and I thought it might be quicker for my queries (tagging of geohashed locations). I'll investigate RTDB again too. Thanks for all of your help.

from geofirestore-js.

MichaelSolati avatar MichaelSolati commented on May 19, 2024

Version 2.2.1 is deployed on NPM.

from geofirestore-js.

hindsricardo avatar hindsricardo commented on May 19, 2024

Looks like this problem now exists in version 3.3.1

from geofirestore-js.

MichaelSolati avatar MichaelSolati commented on May 19, 2024

@hindsricardo can you build a sample application showing this issue?

from geofirestore-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.