Giter Site home page Giter Site logo

Comments (7)

MicheleBertoli avatar MicheleBertoli commented on June 19, 2024 1

Yes, thank you very much @peterpetre.
I'm thinking about a full rewriting of the Components as well as an upgrade of React and a fix for #29 in the next few months.

from react-gmaps.

MicheleBertoli avatar MicheleBertoli commented on June 19, 2024

Hello @peterpetre,
can you please share more details to reproduce the issue?
Thanks!

from react-gmaps.

peterpetre avatar peterpetre commented on June 19, 2024
warning.js:36 Warning: Unknown prop `map` on <span> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in span (created by Gmaps)
    in div (created by Gmaps)
    in Gmaps (created by Sidebar)
    in div (created by Sidebar)
    in div (created by Sidebar)
    in Sidebar (created by Connect(Sidebar))
    in Connect(Sidebar) (created by Sidebar)
    in div (created by Sidebar)
    in Sidebar (created by MeteorDataContainer)
    in MeteorDataContainer (created by Connect(MeteorDataContainer))
    in Connect(MeteorDataContainer) (created by App)
    in div (created by App)
    in App (created by MeteorDataContainer)
    in MeteorDataContainer (created by Connect(MeteorDataContainer))
    in Connect(MeteorDataContainer) (created by RouterContext)
    in div (created by Root)
    in Root (created by MeteorDataContainer)
    in MeteorDataContainer (created by Connect(MeteorDataContainer))
    in Connect(MeteorDataContainer) (created by RouterContext)
    in RouterContext (created by Router)
    in Router (created by Routes)
    in Provider (created by Routes)
    in Routes

This is the whole warning, now on the link they say:

  1. Are you using {...this.props} or cloneElement(element, this.props)? Your component is transferring its own props directly to a child element (eg. https://facebook.github.io/react/docs/transferring-props.html). When transferring props to a child component, you should ensure that you are not accidentally forwarding props that were intended to be interpreted by the parent component.
  2. You are using a non-standard DOM attribute on a native DOM node, perhaps to represent custom data. If you are trying to attach custom data to a standard DOM element, consider using a custom data attribute as described on MDN.
  3. React does not yet recognize the attribute you specified. This will likely be fixed in a future version of React. However, React currently strips all unknown attributes, so specifying them in your React app will not cause them to be rendered.

from react-gmaps.

MicheleBertoli avatar MicheleBertoli commented on June 19, 2024

Thanks @peterpetre,
I had the same error in one of the apps I'm working on but I haven't been able to reproduce it on the react-gmaps demo.
So I was more interested in details about your code or if you can just tell me the way to reproduce the issue using the library.

from react-gmaps.

peterpetre avatar peterpetre commented on June 19, 2024

@MicheleBertoli ok i found out where this warning hits!!

<Gmaps
          ref="gmaps"
          width={'50%'}
          height={'500px'}
          style={styles.cols}
          lat={51.5258541}
          lng={-0.08040660000006028}
          zoom={12}
        >
          <span> TEST TEST TEST </span>
        </Gmaps>

when i have any element which is not from react-gmaps inside the Gmaps component.

from react-gmaps.

MicheleBertoli avatar MicheleBertoli commented on June 19, 2024

Oh, I see @peterpetre.
Do you really need to put a span as a child of the map?
Do you mind if I ask you the reason why you are doing that?
Thanks!

from react-gmaps.

peterpetre avatar peterpetre commented on June 19, 2024

Yea sure,

I have a sidebar, with a small map with directions, and i have a button on the map to make this map fullscreen with an animation.

Now i had some displaying issues on the map being width/height 100% and do it on a parent div, so i have added the button as a child of the map.

But its a bit confusing functionality, so i will try to figure out something else. At least we found from where the warning comes from! :)

from react-gmaps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.