Giter Site home page Giter Site logo

Comments (6)

asim avatar asim commented on April 28, 2024

Easiest fix would probably be to have the sidecar accept a broker.Message rather than filling in the body of a broker.Message with whatever's passed in. It's a breaking change though so it affects anyone already using the sidecar. I'll have to give it some thought.

from micro.

bkleef avatar bkleef commented on April 28, 2024

@asim any thoughts on this?

from micro.

asim avatar asim commented on April 28, 2024

The issue is because of this https://github.com/micro/micro/blob/master/internal/handler/broker.go#L56. I'm open to suggestions on a fix, otherwise I'm not touching it for the moment.

from micro.

asim avatar asim commented on April 28, 2024

An easy solution would perhaps be to take Content-Type from the initial request and use that as the basis for any messages published.

from micro.

asim avatar asim commented on April 28, 2024

Here's a PR to fix it #70. When you connect to the /broker endpoint on the sidecar you specify the content-type header which will then be used for all publications. If a content-type is not specified then it will default to application/json.

It's a bit of a hack of a fix as it doesn't actually allow you to set your own headers.

from micro.

asim avatar asim commented on April 28, 2024

Merged PR.

from micro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.