Comments (4)
Oh, lang
is missing as well (from metascraper-lang)
from metascraper.
@JaneJeon I will accept a PR fixing this 🙏
from metascraper.
What is the preferred way to resolve this? Just make the output contain every single possible type and make it nullable (and optional)? Or somehow compose types package by package?
(I have no idea how you would go about approach 2 - my typescript-fu is too weak)
from metascraper.
Any rule can return string/number/whatever but also null; null means the value isn't being resolved: https://github.com/microlinkhq/metascraper/blob/master/packages/metascraper/src/get-data.js#L6
I think it could be as simple as:
interface Metadata {
author: string | null;
date: string | null;
description: string | null;
image: string | null;
publisher: string | null;
title: string | null;
url: string | null;
}
About why lang
is missing, it's tricky because every property has its package. The lang
will be present if metascraper-lang is is loaded.
What could be nice is to add every property added by any metascraper package with a little description, such as:
interface Metadata {
/* Get lang property from HTML markup. It will be present when `metascraper-lang` is required */
lang: string | null
}
from metascraper.
Related Issues (20)
- Add more integration tests HOT 2
- provide a way to avoid re2 installation HOT 23
- Output keys not set with custom rules HOT 1
- Is there a package for grabbing just the domain? HOT 1
- Wrong Typescript declared types HOT 5
- Not scrapping the correct date HOT 1
- JSDOM dependency is not compatible with node v14 HOT 7
- Missing 'logo' in Metadata interface when using metascraper-logo plugin HOT 1
- Instagram Scraping Give me null at some field HOT 1
- Crash on `metascraper-audio` HOT 4
- Specific pages lead to crash of nodejs HOT 1
- Specific pages crash NodeJS with the usage of metascraper-audio or metascraper-video HOT 3
- New version causes breaks in Definitely Typed packages HOT 9
- Cannot use in Defer because of re2 HOT 1
- Add types for metascraper packages
- metascraper-date typing errors HOT 2
- [metascraper-clearbit] Typescript build error from `keyvOpts` HOT 1
- Any issues with a memory leak, particularly metascraperDescription() HOT 1
- High memory usage HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metascraper.