Specific pages crash NodeJS with the usage of metascraper-audio or metascraper-video

[spgonejoker]

Specific pages crash NodeJS with the usage of metascraper-audio or metascraper-video

[Kikobeats]

Thanks for the report. This is happening due metascraper-audio and metascraper-video are using a getIframe implementation based on JSDOM:

• metascraper/packages/metascraper-video/index.js

  Line 73 in 4f60f1a

  loadIframe(url, $.load(`<iframe src="${src}"></iframe>`))

• metascraper/packages/metascraper-helpers/index.js

  Line 440 in 4f60f1a

  const loadIframe = (url, $, { timeout = 5000 } = {}) =>

This implementation is simple but it isn't working fine for some that contains dynamic code execution. This error has been reported into jsdom repository: jsdom/jsdom#2346

The workaround is to provide your own getIframe implementation. Since you are already using browserless, you can do something like this:

/* Getting iframe using browserless */
const getIframe = async (_, $, { src }) => {
  const { html } = await getHTML(url, { getBrowserless: () => browserContext })
  return $.load(html)
}

const metascraper = createMetascraper([
  require('metascraper-video')({ getIframe }),
  require('metascraper-audio')({ getIframe })
]);

Can you test at your end and tell me back? 🙂

(closing for moving away from issues but feel free to reply!)

[spgonejoker]

Thanks for the workaround, but it's not working.

I added your code (with a little modification)

const getIframe = async (_, $, { src }) => {
  const { html } = await getHTML(src, { getBrowserless: () => browserContext })
  return $.load(html)
}

const metascraper = createMetascraper([
  metaAudio({getIframe}),
  metaVideo({getIframe}),
]);

The src / url looks normal but i get an error, if i call the named urls (here: http://localhost:8085/https%3A%2F%2Fplayout.3qsdn.com%2Ff0e6a0f5-b8ee-11e9-8d5b-0cc47a188158)

node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_INVALID_URL]: Invalid URL
    at new NodeError (node:internal/errors:405:5)
    at new URL (node:internal/url:637:13)
    at exports.default (/app/node_modules/got/dist/source/core/utils/options-to-url.js:35:17)
    at normalizeArguments (/app/node_modules/got/dist/source/core/index.js:486:51)
    at got (/app/node_modules/got/dist/source/create.js:112:39)
    at /app/node_modules/html-get/src/index.js:25:17
    at /app/node_modules/p-cancelable/index.js:20:5
    at /app/node_modules/p-cancelable/index.js:63:11
    at new Promise (<anonymous>)
    at new PCancelable (/app/node_modules/p-cancelable/index.js:31:19) {
  input: 'favicon.ico',
  code: 'ERR_INVALID_URL'
}

Node.js v18.18.2

[Kikobeats]

now the error is pretty different – just debug it a bit!

BTW you can resolve it against Microlink API:

https://api.microlink.io/?url=https://playout.3qsdn.com/f0e6a0f5-b8ee-11e9-8d5b-0cc47a188158&audio&video

Essentially it's the hosted version of this library 🙂