Giter Site home page Giter Site logo

Comments (4)

Kikobeats avatar Kikobeats commented on May 31, 2024

The main reason got is used is because it's one of the most used npm packages in the ecosystem and very actively maintained.

So fortunately at least one of your dependencies is going to install got and the cost will be 0.

what's the code size for node-fetch? asking because bundlephobia can't report the size

https://bundlephobia.com/package/node-fetch

from youtube-dl-exec.

Hazmi35 avatar Hazmi35 commented on May 31, 2024

The main reason got is used is because it's one of the most used npm packages in the ecosystem and very actively maintained.

So fortunately at least one of your dependencies is going to install got and the cost will be 0.

If it's by download usage got stills behind node-fetch, I love got, I used it too, but node-fetch is a better option IMO.
Also @mapbox/node-pre-gyp now uses node-fetch instead of needle, plus I saw youtube-dl-exec usage increasing by discord.js bot developers where discord.js also uses node-fetch

what's the code size for node-fetch? asking because bundlephobia can't report the size

npm's reporting 75.9 kB for v3, but GNU/du is reporting 136K, unfortunately, node-fetch v3 is now pure ESM, meaning it can't be imported from commonjs directly (this is probably why bundlephobia can't report its size, probably it didn't support ESM packages, yet).

For node-fetch v2 npm's reporting 149 kB and GNU/du is reporting 172K, and this is the bundlephobia results
image

from youtube-dl-exec.

Kikobeats avatar Kikobeats commented on May 31, 2024

Thanks for clarifying!

Can you make a PR switching from got to node-fetch@2? I will be happy to merge it 🙂

from youtube-dl-exec.

Hazmi35 avatar Hazmi35 commented on May 31, 2024

Thanks for clarifying!

Can you make a PR switching from got to node-fetch@2? I will be happy to merge it 🙂

Ah sorry for the late response, I can but seeing #38 is already opened, then we'll use that

from youtube-dl-exec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.