Comments (10)
Yeah I ended up adding the patched class to each project. That works for now
from micronaut-grpc.
From my debugger:
If you use the non-blocking client - the reply does happen but the stream observer throws an onError() as well. But the onNext() is called, so replies do happen, but an error occurs with each call.
The blocking stub throws an exception all the time.
Any help is greatly appreciated.
from micronaut-grpc.
I updated the test to have fewer dependencies. Same error.
from micronaut-grpc.
there is a necessary release in grpc-java we are waiting for grpc/grpc-java#10663
from micronaut-grpc.
Bummer - so the release breaks GRPC but we can't fix it until they fix the bug? Why not just downgrade the grpc version since the entire framework is busted with the most recent version?
from micronaut-grpc.
I'm installing the snapshot of grpc-java and I'll let you know if the patch fixes this.
from micronaut-grpc.
OK - the patch makes it work. I just took the patch you outlined and applied it to my code. I'll have to make a quick patch project for these projects, but it'll allow me to use my projects on the latest micronaut then.
I'll commit the patch I made to the project. I'm just adding the same patch and it shows that the tests work now.
Feel free to grab the test I wrote as a part of your tests in the future.
from micronaut-grpc.
Just added the "patch"; I took the java code from the upcoming grpc release and just added it to the jar file. Because it's in the same jar, the patch version will always win.
from micronaut-grpc.
Bummer - so the release breaks GRPC but we can't fix it until they fix the bug? Why not just downgrade the grpc version since the entire framework is busted with the most recent version?
@krickert Yes, unfortunately downgrading the GRPC version doesn't fix the issue, because the older implementations also have the same unimplemented method. The issue appears because Netty 4.1.101 now invokes the missing isEmpty
method whereas it they did not in version 4.1.100 and earlier. I believe temporarily downgrading to Netty 4.1.100 would also work until GRPC releases the patch in 1.60 which they say will happen on Nov 28th.
from micronaut-grpc.
Yesterday the latest grpc version fixes this. However, it breaks it in other ways, from what I can see. I keep getting an error for io.grpc.internal.AbstractServerImplBuilder not found when updating the library
from micronaut-grpc.
Related Issues (20)
- GRPC embedded server fails with `@MicronautTest(rebuildContext=true)` HOT 1
- breaking change not exposing micronaut-runtime
- Dependency Dashboard
- Memory Leak in ByteBufToProtoMessageConverter.java:57 HOT 1
- Support `ServerInterceptors` HOT 3
- GRPC Graal tests failed after upgrading to Netty 4.1.84
- Feature Request: avro-support (I can code it - just need a gradle project to get me going) HOT 3
- Template is outdated
- Migrate to new configuration ascidoc macro
- grpc now supports the following client lib automated retry & resiliency features HOT 3
- Cucumber Micronaut test: Embedded gRPC server not starting
- gRPC Documentation generation fails
- Retry on Client Side HOT 1
- Add com.google.protobuf:protobuf-kotlin to Micronaut BOM
- round_robin for gRPC client does not work with Kubernetes service discovery
- Del @Deprecated gRPC HOT 1
- `ClassNotFoundException` when not using discovery HOT 4
- How to pass password of encrypted private key when enabling grpc.ssl HOT 7
- Grpc request failing with "onStreamError" on enabling ssl and http2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from micronaut-grpc.