PublishToEnvironment not recognizing environment from settings in private repo

[microsoft]

PublishToEnvironment not recognizing environment from settings in private repo

[freddydk]

If you have an environment called QA - you need to create a secret in that environment called AUTHCONTEXT.
If you don't use the environments feature in GitHub, the secrets needs to be called QA-AUTHCONTEXT to match the environment.

[freddydk]

Found the bug, will deploy a fix for this tomorrow.

Reason is that your GitHub account is a free account - it works if you have a Teams or Enterprise account. But then again - the environments setting was introduced in order to work when using a free account - it of course must work.

[freddydk]

Shipped in v1.2 - if you update your AL-Go system files, you should be good to go.

[curateideas]

Works now, thank you for your immediate response.

Have a follow-up issue with the secrets. After investiation will create another issue for that or a PR.

[curateideas]

Second case is the issue: the corresponding script searches for "AUTHCONTEXT" in the repository secrets instead of "QA_AUTHCONTEXT". This way there is only one connection to an environment that can be configured per Repo.

In PublishToEnvironment.yaml:

I'm testing a fix in a fork at this moment.

[freddydk]

Right on top - it is looking for QA-AUTHCONTEXT (line 88) - needs to be a dash, not an underscore, sorry

[curateideas]

Dash is not allowed for a repo secret name since it seems it is reserved for concatenation of the environment secrets:

[freddydk]

bummer - it works in an Azure KeyVault - will make a fix for supporting dash or underscore.
Thanks for reporting.

[freddydk]

Did not test the PR yet - but this should add support for looking for both QA-AUTHCONTEXT and QA_AUTHCONTEXT
Probably the same solution as you have been looking at in your fork.

You can merge update your fork and deploy new al-go repos in your org to test this (I assume you use your own local repos as al-go templates if you have a fork:-))

[curateideas]

Again: Thanks, Freddy! Will check this out.

[curateideas]

Now working as expected!

I made nearly the same changes but struggled with the End2End Tests, before submitting the PR. There's a learning curve for me...

[freddydk]

yeah - I will document what you need in order to run the End 2 end tests - they are fairly heavy - they test out a ton of various things including upgrades from all prior versions to the new...

[curateideas]

Is the fix deployed to AL-Go-PTE already? I see no PR in my project after Update System Files.

[freddydk]

Not yet - will do so today or tomorrow

[freddydk]

BTW - there is another way this can be fixed.
You can create a setting called QA-AUTHCONTEXTSECRETNAME with the value QA_AUTHCONTEXT

There is a generic way in AL-Go to rename secrets by adding a setting called <secret>SECRETNAME

The reason for this is that multiple repositories can share a KeyVault and might have different secrets (like this)
I will still checkin the fix to utilize the _ as that is clearly a bug.