Make the API more Swifty

[sindresorhus]

Make the API more Swifty

[tonyarnold]

@jaeklim none of @sindresorhus has suggested requires you to use Swift directly.

This can all be done by properly structuring your Objective-C API using properties (both instance and class properties). I'll draw up a PR with at least what @sindresorhus has suggested above as an exemplar.

[AnastasiaKubova]

The feature has been released in 4.0.0 version of App Center.

[annakocheshkova]

@sindresorhus thanks for the suggestion. We are always open to the ways to improve the SDK.

[jaeklim]

@sindresorhus I appreciate your suggestion for Swift methods of App Center SDK. Unfortunately, it is not in our immediate plan to support it. We will keep this thread open for developers to comment and vote, and keep you posted once we decide to work on it.

[Jamminroot]

@tonyarnold sure, feel free to create PR.

[iamclement]

Thanks for bumping up the topic and submitting a PR @tonyarnold . This is indeed some good improvements we can take, we are welcoming contributions. We’ll review the PR. FYI among other thing we are looking at to approve a PR is the consistency between modules particularly because this topic impacts all modules. If any breaking change is to be added it should be added in a separate PR because it’ll probably stack up until the next SDK major version will show up. If we think we need to iterate on this we can create feature branches.

[tonyarnold]

Please pass on my thanks to your team, @AnastasiaKubova 😁

[sindresorhus]

Really nice work on this everyone.

---

I did notice one thing though. It went from MSAppCenter.isEnabled() to AppCenter.enabled. This should be AppCenter.isEnabled.

[vvechkanov]

Hi @sindresorhus!
We are glad that you like our work! What about your note we were considering both options and decide to write it this way. Here you can found our PR, with discussion. The main idea was consistency between ObjC and Swift code. We use AppCenter.enabled as a name for property and is_ and set_ as prefixes for getters and setters.

[sindresorhus]

The whole point was to swiftify the API, meaning less consistency between Swift and Objective-C. Why not do it 100%?

[DmitriyKirakosyan]

@sindresorhus, we considered and discussed it thoroughly within the team while doing these changes, and it was decided to use enabled in Swift as this property is mutable.

I'm sorry to inform you that, but we are not planning to do any updates related to Swift-friendly API.