Comments (3)
@tobiasdiez thank you very much for the input. I will soon push out a PR. But most likely, it won't be a part of stable release of 2.0.0-BETA, instead would come out in 2.0.1 release as this would be a new feature, and just would defy the transition of Beta to stable.
from applicationinsights-java.
@tobiasdiez could you please shed some more details on this issue? Also, I see you suggesting a fix in the issue discussion. We are very open to contributions and would be really great if you could send a PR if it is possible ?
from applicationinsights-java.
Sadly, I don't have time right now to create a PR but, of course, I'm happy to provide more details.
The default log4j2 appender accept the options filter, layout, ignoreExceptions
(see AbstractAppender). The ApplicationInsightsAppender
should also support these basic settings. For this, the factory method
https://github.com/Microsoft/ApplicationInsights-Java/blob/36214d5c28eb975e008c5b7c60c4840fdd10ec20/logging/log4j2/appenderSrc/main/java/com/microsoft/applicationinsights/log4j/v2/ApplicationInsightsAppender.java#L81-L83
needs to be extended by the arguments @PluginAttribute("ignoreExceptions") boolean ignoreExceptions, @PluginElement("Layout") Layout layout, @PluginElement("Filters") Filter filter
(see log4j documentation for an example. What is not shown in the example is that you simply pass these arguments to the parent constructor.).
Moreover, the log4j documentation suggests to use the builder pattern.
from applicationinsights-java.
Related Issues (20)
- Download URL format changed in 3.5.0 HOT 3
- Operation name/ Operation id missing for manual created threads HOT 7
- Azure ApplicationInsights stopped reporting Query paramters in Request traces - With 3.5.0 HOT 1
- Adding per-worker metrics reported to JMX in applicationinsights.json for App Insights HOT 4
- Question: azure log analytics workspace migration HOT 1
- Q: regarding client secrets support HOT 1
- CVE-2023-52428 HOT 2
- Application Insights runtime attach agent metric-filtering not working HOT 10
- Is there a way to sample overrides Servicebus requests? HOT 18
- Workflow failed: OWASP dependency check (daily) (#532) HOT 1
- Workflow failed: OWASP dependency check (daily) (#542)
- Workflow failed: OWASP dependency check (daily) (#547)
- Sampling based on dependency result HOT 2
- OpenTelemetry support for MQTT pub/sub with Application Insights Java agent HOT 1
- Ignore newline and carriage return in the connection string file
- Sampling override based on request processing time? HOT 7
- Support for OTEL Synchronous Gauge HOT 3
- ignore InProc sampling dependencies
- Sampling override with http.response.status_code doesn't work HOT 5
- MySql dependency tree not available with applicationinsights-agent-3.5.1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from applicationinsights-java.