Comments (4)
Since any change would be breaking, lets add comments around this behavior in that class. There is probably a bit more history here since the other app types were added later.
from botbuilder-js.
Hi @XVincentX,
The CertificateAppCredential class has the tenantId
parameter marked as optional and defaults to botframework.com
because of MultiTenant apps.
BotBuilder supports multiple types of apps to authenticate, MultiTenant, SingleTenant and UserAssignedMSI (more info). Thus, by providing a tenantId
for MultiTenant apps other than the default, the authentication will not work.
Additionally, the default value is also required for MultiTenant, and changing it will break MultiTenant authentication.
from botbuilder-js.
- Aren't multi tenant application supposed to use
common
as tenant name? Whybotframework.com
? - Would it make sense to have whatever value is required as default of the constructor, rather than setting it somewhere in the code, making unclear what is really happening?
from botbuilder-js.
"botframework.com" has been the default tenant in AppCredentials, however subclasses can change this. As in the case of Gov cloud where its "MicrosoftServices.onmicrosoft.us". Though the option is there to specify a different tenant in the constructor.
Most of this dates back far, when there was only MultiTenant auth. It would appear that it just wouldn't be possible to change without creating a breaking change. There probably is a clearer way if we were green rooming it.
Also, the credential factories, which is central to CloudAdapter have tenantId as optional too. For example, CertificateServiceClientCredentialsFactory.
from botbuilder-js.
Related Issues (20)
- replyToId not part of token response of oauthprompt HOT 12
- @azure/msal-node and @azure/msal-browser versions are deprecated (both have new major versions)
- Add support for isVisible property in SharePoint Bot Adaptive Card Extension
- 'yarn' command not found while installing 'botbuilder-dialogs' HOT 2
- Cannot catch MemberNotFoundInConversation error when calling getConversationPagedMembers HOT 7
- port: Add zh-cn to supported locales HOT 1
- handleTeamsMessagingExtensionCardButtonClicked method is not working. HOT 11
- Support Federated Identity Credential HOT 2
- Adaptive card reverting back after reacting to it in Teams
- Support for multi-instance app customization in Teams?
- TeamsInfo.getTeamChannels returning 403 Service Error Unknown HOT 2
- Facing FetchError: request to https://login.botframework.com/v1/.well-known/openidconfiguration failed, reason: unable to get local issuer certificate
- Skype is not sending the attachment details along with request object in group chats HOT 6
- `Input.Text` not displaying when used with `isRequired: true` HOT 1
- Update axios in botbuilder-core from 0.28 to 1.6.4 HOT 3
- Why the thumbnailCard image has a extra `margin-top: 0.8rem;` style?
- contentType for excel attachment HOT 5
- Channel moderation settings are evaluated incorrectly when posting as a bot. HOT 6
- Teams botbuilder inline attachment download stopped working HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from botbuilder-js.