Comments (2)
TessFerrandez
commented on July 4, 2024
This issue seems to be at least partially covered already in the PR General Guidance.
- In the daily standup meeting check tasks pending for review and make sure they have reviewers assigned.
- Junior teams and teams new to the process can consider creating separate tasks for reviews together with the tasks themselves.
Regarding having a code reviewer assigned per user story / task, I don't agree with this. Assigning a task or a PR to someone before it can actually be worked on can create problems as that person may or may not be available to work on it when it needs to be done. I am also unsure how that would help with discipline and planning effort.
We already have guidance around adding relevant reviewers, and making sure that PRs get owners.
I also don't understand the 3rd point here, "how do you make the effort predictable with changing PR size" can we elaborate on this?
from code-with-engineering-playbook.
TessFerrandez
commented on July 4, 2024
Closing per discussion on teams
from code-with-engineering-playbook.
Related Issues (20)
- Create a new scanning page
- Rename and update "Rules of Engagement"
- Update Security Overview page
- Update Security Navigation
- Create new page for Authentication
- Create new page for Authorization
- New page for Key Vault
- [BUG] Some playbook links lead to the rendered docs, others to the repo
- ADR IDs can be bound to work item ID
- Add a section on evaluating OSS
- Guidance and examples informing around Structural vs Behavior Diagrams HOT 1
- Retrospective link broken
- Microsoft REST API Guidelines Deprecation HOT 2
- [BUG] Feasibility study report needs update and markdown issues
- Gaps in security mindset
- [BUG] Broken links
- Microsoft Defender for Cloud HOT 1
- Update Engineering Fundamentals Checklist
- Add Threat Modeling Materials
- AKS Security & Identity
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from code-with-engineering-playbook.