Comments (11)
Yeah that is obviously not a good experience. Let us take a look into this and see what we can do to mitigate it. Stay tuned!
from cordova-plugin-code-push.
Thanks for reporting this issue. One of our plugin dependencies (the file transfer plugin) does add the write external storage to the Android manifest file, which under the new permission rules, is a dangerous permission. However, to my knowledge, we never use that permission since we download the files to the application sandbox, not the phone external storage. So in theory, we should not see that permission dialog when installing the update.
Can you give me more details about your scenario?
- What kind of build are you running? Debug or release? Do I need to sign the apk?
- Were you on a device or emulator when reproducing the issue?
I tried to reproduce it on an emulator with a debug build unsuccessfully.
One quick way to fix this issue is to change your android target version to 22 like this (in config.xml):
<platform name="android">
<preference name="android-minSdkVersion" value="YOUR_MIN_SDK_VERSION" />
<preference name="android-targetSdkVersion" value="22" />
</platform>
Make sure your minimum sdk version is at most 22 as well. But this is not ideal and if this is a real issue we need to look into it.
from cordova-plugin-code-push.
popup comes:
- tested on actual device (nexus 5), debug build
popup doesn't come:
- emulator (nexus 5), debug build
from cordova-plugin-code-push.
setting the android-targetSdkVersion
to 22 does fix it though.
from cordova-plugin-code-push.
I just looked into this. The bug is caused by the Cordova file plugin, which, in its current release, always asks for the storage permission with any storage operation regardless of whether or not it actually requires it. They've fixed the issue, but it's not yet released. We could a quick modification to the plugin.xml file to resolve the problem and then revert the changes once they've made a release.
<dependency id="cordova-plugin-file" url="https://github.com/apache/cordova-plugin-file.git" commit="1e2593f42455aa78d7fff7400a834beb37a0683c" />
<dependency id="cordova-plugin-file-transfer" version=">=1.3.0" />
(it is important that file is before file-transfer in the dependencies, because otherwise file-transfer's dependencies install first and ignore what we specify here)
from cordova-plugin-code-push.
The guys that fixed the bug are Microsoft employees. We should understand what is the timeline of the release before changing the dependency, since we already have a workaround.
from cordova-plugin-code-push.
@rakatyal What is the schedule for releasing a new version of the Cordova file plugin to npm? We have this related issue in the CodePush plugin.
from cordova-plugin-code-push.
@dlebu: We have a plugin release in process right now. It should be out soon. I will update this thread once it's done.
from cordova-plugin-code-push.
@rakatyal Thanks a lot!
from cordova-plugin-code-push.
The release has passed and I expect the npm packages to be released today or tomorrow. You can track the progress by following this mail thread.
from cordova-plugin-code-push.
This issue has been resolved and will be released to NPM this afternoon.
from cordova-plugin-code-push.
Related Issues (20)
- Can this plugin pass the Google market audit
- Cannot install code push cordova plugin
- Does the ` appcenter codepush release-cordova ...` work on Windows for iOS Apps? HOT 2
- Slow down support
- Application is stuck while getting update from appcenter codepush
- `CODE_PUSH_APK_BUILD_TIME` slows down builds recompiling resources unecessarily.
- [Feature] Support Capacitor for AppCenter CodePush (Solved)
- Google Play Console reports security error: Zip Path Traversal Error due to cordova-plugin-zip dependency HOT 1
- Error: An error has occurred while performing the operation
- This plugin is compatible with capacitor and UIWebView reference free ? HOT 1
- [CodePush] Could not access local package. Stage:undefinedError code: undefined HOT 2
- [ERROR] could not get binary hash.Error: Could not get binary hash. HOT 1
- cordova-plugin-code-push dependency overrides AFNetworking files
- [CodePush] Update is rolling back after app relaunch HOT 1
- How to change url when startloading files?
- Make an official version for CapacitorJS HOT 2
- Support for cordova-android>=10.0.0 WebViewAssetLoader default HOT 1
- net::ERR_ACCESS_DENIED on codepush install after changing Android API target to 30 HOT 1
- Could not get binary hash.Error: Could not get binary hash.
- A Code Push Alternative - Ionic Appflow HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-code-push.