Git menu will trigger commit call on every click

[microsoft]

Git menu will trigger commit call on every click

[ewoutkramer]

A PR will follow shortly.

[ACMoretxj]

Hi Ewout, I can't reproduce the issue, it seems that the dropdown menu and the commit link(inside the dropdown menu) all work normally without functional interleaving on my machine. Could you please provide more detailed context information or screenshots?

[ewoutkramer]

The event that triggers the call to commit seems to be attached to the element #git-dropdown - when I had commitable changes, every time I would just click the dropdown so it would open, I saw a commit being sent to the api endpoint. So, I changed to code to be attached to the <a> link. But I see now that the on() actually has the name of the child anchor there. Hum.

And I cannot reproduce it anymore, since I upgraded my node installation, and now all the Git functions don't work anymore anyway. I'll try downgrading node and see if I can reproduce it again.

[ewoutkramer]

Can't reproduce it myself anymore. I'll close this until I hit this issue again ;-)

[ACMoretxj]

Thank you Ewout, I will inform my teammates to pay attention to the GIT menu functions too, and please feel free to reactivate this issue for any questions :)