SETNX is not implemented

[yeurch]

SETNX is not implemented

[mgravell]

For context: we frequently run into problems when defaulting to newer commands, because generally servers support the older commands even when they have been superceded, but many servers do not yet support the newer commands; this could be because the server simply doesn't support it, or could be because the instance hasn't been updated in forever, and it isn't worth the outage. My recommendation: Garnet should support both :) Likewise: HMSET even though HSET now allows the same functionality

…

On Fri, 12 Apr 2024, 19:38 Marc Gravell, ***@***.***> wrote: Looks like it universally prefers SETNX - at least when dealing with Redis, this gives wider coverage without needing a server version check ( https://github.com/StackExchange/StackExchange.Redis/blob/main/src/StackExchange.Redis/RedisDatabase.cs#L4443 ) On Fri, 12 Apr 2024, 18:46 Badrish Chandramouli, ***@***.***> wrote: > @mgravell <https://github.com/mgravell> - do you know under what > condition db.StringSet("my_key", "value1", null, When.NotExists) in > SE.Redis would use the deprecated SETNX versus what Garnet supports, SET > .. NX? > > — > Reply to this email directly, view it on GitHub > <#270 (comment)> > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAEHMHVP32IX4BP2SMLOQ3Y5AMWNBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TQNZQG43TQNZUHGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRWG4YTIMJQGE3TAMNENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTMOBRGM3TEOBXGGBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZDGOBXGUYTKOBWQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRVHA3TANZXHA3TIOMCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNRXGE2DCMBRG4YDDJ3UOJUWOZ3FOKTHK4DEMF2GK> > . > You are receiving this email because you were mentioned. > > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> > . > >

[TalZaccai]

Hi @yeurch! Thanks for bringing that to our attention. That's a mistake in the API Compatibility page, I'll have it updated.

In any case, SETNX is now considered deprecated by Redis (https://redis.io/docs/latest/commands/setnx/), and can be replaced with running SET with the NX argument, so I don't believe we'll be implementing that one, unless there's a specific need.

If you're using SERedis, you can run (string)db.Execute($"SET", key, value, "NX") instead

[yeurch]

Thanks for digging into this @TalZaccai. I hadn't realized that the command was deprecated, sorry. I guess this could be a philosophical debate ... does Garnet intend to be fully compatible with Redis? If so, I'd argue these should be implemented, otherwise it's not 100% compatible. But they've been marked as deprecated for so long by Redis that I guess it's a tough call.

Another interesting point is that StackExchange.Redis, which you mention in your very first bullet point in the README, appears to use SETNX key val rather than SET key val NX. If this client is widely in use, then I think it could cause issues for many users. db.SetString() seems to be the "normal" way to do sets from SERedis, and having to switch to the lower level db.Execute("SET", ...) could cause confusion.

[badrishc]

@mgravell - do you know under what condition db.StringSet("my_key", "value1", null, When.NotExists) in SE.Redis would use the deprecated SETNX versus what Garnet supports, SET .. NX?

[mgravell]

Looks like it universally prefers SETNX - at least when dealing with Redis, this gives wider coverage without needing a server version check ( https://github.com/StackExchange/StackExchange.Redis/blob/main/src/StackExchange.Redis/RedisDatabase.cs#L4443 )

…

On Fri, 12 Apr 2024, 18:46 Badrish Chandramouli, ***@***.***> wrote: @mgravell <https://github.com/mgravell> - do you know under what condition db.StringSet("my_key", "value1", null, When.NotExists) in SE.Redis would use the deprecated SETNX versus what Garnet supports, SET .. NX? — Reply to this email directly, view it on GitHub <#270 (comment)> or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEHMHVP32IX4BP2SMLOQ3Y5AMWNBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI2TQNZQG43TQNZUHGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRWG4YTIMJQGE3TAMNENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTMOBRGM3TEOBXGGBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZDGOBXGUYTKOBWQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRVHA3TANZXHA3TIOMCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNRXGE2DCMBRG4YDDJ3UOJUWOZ3FOKTHK4DEMF2GK> . You are receiving this email because you were mentioned. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

[badrishc]

This makes sense, thanks!