Troubling compiling with ResourceReader

[microsoft]

Troubling compiling with ResourceReader

[agrittmsft]

Hi, could you try looking at your C++ Language Standard option? The SDK is built using C++14 or higher. Several of the std::max implementations were added only in C++ 14 https://en.cppreference.com/w/cpp/algorithm/max

Right click Project -> Properties
-> Configuration Properties
-> C/C++
-> Language
-> C++ Language Standard
= ISO C++14 Standard (/std:c++14)

[agrittmsft]

If that doesn't work you could try adding this at the top of Sample3DSceneRenderer.cpp

#include <limits>

[chriche-ms]

This problem is caused by Windows.h defining min and max macros which then break any usage of std::min/max and std::numeric_limits::max. The easiest fix is to add #define NOMINMAX before any of the #includes in pch.h (this can also be done via the C/C++->Preprocessor->Preprocessor Definitions property on the project's properties page).

Once you make this change you'll need to replace a few usages of the min/max macros in DeviceResources.cpp with std::min/max. Don't forget to change the integer literals to floats (e.g. std::max(m_outputSize.Width, 1.0f)) or you'll get some strange compile errors!

[viperscape]

@chriche-ms that worked, thank you! now compiling
@agrittmsft your suggestions unfortunately did not help, as well I think VS min lang version was at 14, but I tried 17 just in case. Thank you though!

[gaetandezeiraud]

I proposed a fix when #define NOMINMAX is not possible. #55