Giter Site home page Giter Site logo

Comments (6)

bghgary avatar bghgary commented on July 3, 2024

I'm okay with this. @agrittmsft @chriche-ms Any thoughts?

from gltf-sdk.

agrittmsft avatar agrittmsft commented on July 3, 2024

So this is just a refactor without any real functional changes? Sounds good to me.

from gltf-sdk.

zeux avatar zeux commented on July 3, 2024

The only functional change would entail getting (through refactoring) support for a full set of quantized types for geometry attributes without having to hard-code them (e.g. 8-bit normalized signed integers for normals) - which is currently outside of the set of types mandated by the spec but is useful to reduce the data size.

from gltf-sdk.

agrittmsft avatar agrittmsft commented on July 3, 2024

What would be the new way to perform that type validation?

from gltf-sdk.

agrittmsft avatar agrittmsft commented on July 3, 2024

Maybe something like this?

  1. The completely generic data handler function which you're describing
  2. A wrapper for (1) which takes std::pair<std::set, std::set> (+ maybe bool normalized?) and throws accordingly
  3. Individual wrappers for (2) for specific data types (e.g. Normals)

from gltf-sdk.

zeux avatar zeux commented on July 3, 2024

Can you clarify why the validation is necessary? OTOH I don’t think glTF SDK currently thoroughly validates the document on parse. Would help to understand the specific desirable validity criteria that apply here.

from gltf-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.