gltf-sdk build failures with latest rapidjson on macOS

[microsoft]

gltf-sdk build failures with latest rapidjson on macOS

[PolygonalSun]

Hey @PhoebeHui, I can probably take a look this week and see what's going on.

[bghgary]

@SergioRZMasson Can you take this one?

[SergioRZMasson]

@PhoebeHui , it seams that rapidJSON had a contract changes that are problematic on clang. I will be creating a PR with the fixes today.

[PhoebeHui]

@SergioRZMasson, sorry for my late response, we have updated to use gltf-sdk latest commit, which unblock the x64-osx triplet in vcpkg. thank you for your help!

[PhoebeHui]

Related to #94

[SergioRZMasson]

Sorry @PhoebeHui , I think I've miss understood what you guys were trying to achieve. We might have a problem with this change. Since rapidjson had some API changes we had to do changes to our code to support the latest version of rapidjson that makes it incompatible with the version currently at vcpkg. We have validation tests that checks if gltf-sdk using vcpkg and those are going to fail with these new changes.

I believe the only way to go is for us to disable these tests temporarily and wait for you guys to update your rapidjson version (that should now work with our master) and then we can bring those integration tests back. Does that work for you guys?

[SergioRZMasson]

@PhoebeHui , with the update we did to gltf-sdk some features are broken when using rapid-json older than the one used in this repo (older than 232389d4f1012dddec4ef84861face2d2ba85709). You guys have a version in vcpkg that is older than that. Do you guys have plans to update it? Otherwise, gltf-sdk might have some incorrect behavior when used with vcpkg.

[PhoebeHui]

@SergioRZMasson, sorry I missed this message!

I have double checked, rapodjson has been updated to 232389d4f1012dddec4ef84861face2d2ba85709, see https://github.com/microsoft/vcpkg/blob/master/ports/rapidjson/portfile.cmake#L5.