Comments (3)
Just as an addendum here, we also need to make sure iOS + bluetooth keyboard maintains focus outlines, since I think that's the line enabling that behavior now.
Also windows desktop SRs in scan mode/virtual cursor don't currently show focus outlines, even with that check. VoiceOver on macOS does rely on that check, though is somewhat less important since it has its own cursor outline & generally users are not encouraged to use the tab key.
from keyborg.
My suggestion for how to proceed, based on BizChat wanting this fixed quickly as a ship-blocker would be:
- remove the
buttons: 0
heuristic entirely for now. Maybe also the clientX/clientY/etc heuristic too, since at a quick glance that didn't seem to be catching any modern SRs. - Look into adding
:focus-visible
as a focus selector in addition to the tabster data attribute (i.e. so the focus style shows if either the data attribute is present, or:focus-visible
matches) in@fluentui/react-tabster
The second one would help us have more robust focus styles in general, and get us out of the trap of trying to use heuristics to detect ATs. That way the data attribute is primarily a fallback for browsers that don't support focus-visible
yet
from keyborg.
fixed #80
from keyborg.
Related Issues (11)
- KeyborgCallback not exported HOT 2
- Keyborg focusin event should include information if the focus was moved as a result of pressing `Tab` HOT 1
- Add export maps
- Keyboard navigation state is triggered when user types in an input field HOT 1
- KeyborgState not updated when render two react projects HOT 3
- Any keypress from editable elements does not set keyboard navigation mode
- Cover base scenarios with Playwright tests HOT 1
- bug: DTS breaking changes starting v2.4.x - errors on typescript 3.9 HOT 2
- Keyborg instance is being disposed incorrectly. HOT 3
- Long touch can trigger focus border when focus is moving from one element to another
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keyborg.