Giter Site home page Giter Site logo

Comments (3)

smhigley avatar smhigley commented on June 18, 2024 1

Just as an addendum here, we also need to make sure iOS + bluetooth keyboard maintains focus outlines, since I think that's the line enabling that behavior now.

Also windows desktop SRs in scan mode/virtual cursor don't currently show focus outlines, even with that check. VoiceOver on macOS does rely on that check, though is somewhat less important since it has its own cursor outline & generally users are not encouraged to use the tab key.

from keyborg.

smhigley avatar smhigley commented on June 18, 2024

My suggestion for how to proceed, based on BizChat wanting this fixed quickly as a ship-blocker would be:

  1. remove the buttons: 0 heuristic entirely for now. Maybe also the clientX/clientY/etc heuristic too, since at a quick glance that didn't seem to be catching any modern SRs.
  2. Look into adding :focus-visible as a focus selector in addition to the tabster data attribute (i.e. so the focus style shows if either the data attribute is present, or :focus-visible matches) in @fluentui/react-tabster

The second one would help us have more robust focus styles in general, and get us out of the trap of trying to use heuristics to detect ATs. That way the data attribute is primarily a fallback for browsers that don't support focus-visible yet

from keyborg.

micahgodbolt avatar micahgodbolt commented on June 18, 2024

fixed #80

from keyborg.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.