Giter Site home page Giter Site logo

Comments (1)

derekbekoe avatar derekbekoe commented on May 17, 2024

Done:

  1. I've made get_op_handler and user_confirmed private. create_command() is a method I expect may be overridden so not marked that as private.
  2. Removed "CommandSuperGroup" and removed module_name since it's not actually used.

Not done / Open to discussion:
2. Knack wouldn't use these kwargs so would rather leave that up to the caller to subclass the command loader if they want this.
3. Going to leave knack without this for now. If it does become beneficial, we can add it later. Right now, I think there's a single clear way to do it.
5. I believe the same thing can be achieved by just using kwargs on CommandGroup. Not sure what benefit wrapping it in CLICommandType does?
6. I'd prefer not to bring the concept of 'command modules' into Knack.

from knack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.