Issue #4394 not resolved - All my group has been duplicate

[kevin14389]

Issue #4394 not resolved - All my group has been duplicate

[andikrueger]

Could you please share some more information about the issue and how we can reproduce on our end?

[eriel369]

is there a ' in the displayname of the group ? I have had this issue with apostrophes.

[kevin14389]

No, we have no ' in the displayname, just an hyphen.

How to reproduce this problem :

• We export all the group
• We manually change the DisabledPlans when the AssignedLicences is not null in the previous created .PS1 file
• We save the .ps1 file
• We execute the .ps1 file to create the .mof
• We apply the new .mof file with Start-DscConfiguration -Path Folder Created With Previous Step

This was working perfectly before.

[sp74fg2]

I was a bit impatient and ignored the warnings from the test run (hoping it was due to something else) --> also got me some duplicated groups. I do have IDs in the config but to different tenants so I'm falling into a incorrect "fix" via https://github.com/microsoft/Microsoft365DSC/pull/4370/files#diff-21e85585dbcfad3a814015a305f2c306a15cf27bc860e2b6d321c1142329d500 (it also replaced the single quotes of the filter instead of just the $DisplayName variable content resulting in an error on the "get").

Microsoft365DSC/Modules/Microsoft365DSC/DSCResources/MSFT_AADGroup/MSFT_AADGroup.psm1

Lines 150 to 151 in 6d73894

	$filter = "DisplayName eq '$DisplayName'" -replace "'", "''"
	$Group = Get-MgGroup -Filter $filter -ErrorAction Stop

the above should be changed to the same fix as @NikCharlebois did a couple lines down

Microsoft365DSC/Modules/Microsoft365DSC/DSCResources/MSFT_AADGroup/MSFT_AADGroup.psm1

Lines 169 to 174 in 6d73894

	if ($DisplayName.Contains("'"))
	{
	$DisplayName = $DisplayName -replace "'", "''"
	}
	$filter = "DisplayName eq '$DisplayName'"
	$Group = Get-MgGroup -Filter $filter -ErrorAction Stop

[kevin14389]

All the groups are like this : LGG-***-Microsoft 365 E3
Just replace the *** by a name with no character.
Also, we use always the same Id.

For exemple :

`

tututu

    AADGroup "AADGroup-LGG-TUTUTU-Microsoft 365 E3"
    {
        ApplicationId                 = $ConfigurationData.NonNodeData.ApplicationId;
        AssignedLicenses              = @(MSFT_AADGroupLicense 
                                        { 
                                        DisabledPlans = @('ADALLOM_S_DISCOVERY')
                                        SkuId         = 'SPE_E3'
                                        }
        );
        CertificateThumbprint         = $ConfigurationData.NonNodeData.CertificateThumbprint;
        Description                   = "Microsoft 365 E3 collaboration license for TUTUTU";
        DisplayName                   = "LGG-TUTUTU-Microsoft 365 E3";
        Ensure                        = "Present";
        GroupTypes                    = @("DynamicMembership");
        Id                            = "11a11a11a-11a1-1111-1ab1-1115e0511100";
        MailEnabled                   = $False;
        MailNickname                  = "***";
        MemberOf                      = @();
        MembershipRule                = "";
        MembershipRuleProcessingState = "On";
        Owners                        = @();
        SecurityEnabled               = $True;
        TenantId                      = $OrganizationName;
    }

## tatata
    AADGroup "AADGroup-LGG-TATATA-Microsoft 365 E3"
    {
        ApplicationId                 = $ConfigurationData.NonNodeData.ApplicationId;
        AssignedLicenses              = @(MSFT_AADGroupLicense 
                                        { 
                                        DisabledPlans = @('ADALLOM_S_DISCOVERY')
                                        SkuId         = 'SPE_E3'
                                        }
        );
        CertificateThumbprint         = $ConfigurationData.NonNodeData.CertificateThumbprint;
        Description                   = "Microsoft 365 E3 collaboration license for TATATA";
        DisplayName                   = "LGG-TATATA-Microsoft 365 E3";
        Ensure                        = "Present";
        GroupTypes                    = @("DynamicMembership");
        Id                            = "11a11a11a-11a1-1111-1ab1-1115e0511100";
        MailEnabled                   = $False;
        MailNickname                  = "***";
        MemberOf                      = @();
        MembershipRule                = "";
        MembershipRuleProcessingState = "On";
        Owners                        = @();
        SecurityEnabled               = $True;
        TenantId                      = $OrganizationName;
    }

`

I hope this will help you.