Comments (5)
I didn't try this solution. If @wangdevmgit confirm that it works I'll create a PR
from openssl.
uncomment https://github.com/Microsoft/openssl/blob/OpenSSL_1_0_2_WinRT-stable/ms/winrtdef.h#L24-L39 for 10.0.14393.0 SDK,
or the best wrap this into ifdef
#if !defined(NTDDI_WIN10_RS1) || (NTDDI_VERSION <= NTDDI_WIN10_RS1)
...
#endif
from openssl.
Thanks @afedchin,
Would you want to create a pull request and I can merge the change.
It gets challenging sometimes to try to validate all the combinations on SDKS.
from openssl.
Hi @afedchin ,
I have tried your first solution, tt works.
uncomment https://github.com/Microsoft/openssl/blob/OpenSSL_1_0_2_WinRT-stable/ms/winrtdef.h#L24-L39 for 10.0.14393.0 SDK,
However, I didn't try your the ifdef solution because I don't know how to do it.
Also, I modified LIBPATH in setVSvars.bat , because I met a compile-error : error C1107: could not find assembly 'windows.foundation.foundationcontract.winmd'
from openssl.
Merged. Thanks for the change.
from openssl.
Related Issues (20)
- Provide Windows binaries for OpenSSL in order to develop without Perl HOT 2
- Cannot build windows 10 x64! HOT 2
- uwp builds with nmake will fail WACK testing HOT 4
- Question: Engine static libraries missing?
- Build Batch Files Update for VS2017 HOT 1
- VS2017 Support HOT 4
- Windows10Universal command line test HOT 2
- This is how building for VS2017 works for me... HOT 4
- VS2015 link errors
- OpenSSL 1.0.2n HOT 4
- Bump OpenSSL to 1.0.2o HOT 3
- Fails Windows Store App Certification HOT 2
- What are the branches for, which one should be used? HOT 1
- Errors while compiling with RS4 (10.0.17134.0) Windows SDK HOT 6
- openssl-1.0.2p local build error with vs2015 HOT 9
- OpenSSL 1.1.1 (LTS) HOT 7
- Do we have plan to create openssl 1.0.2r branch for UWP platform? HOT 2
- What about the next step of this repo?
- update openssl to 1.0.2s HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openssl.