[Feature]: Add @Inherited to @UsePlaywright

[otbe]

[Feature]: Add @Inherited to @UsePlaywright

[uchagani]

Thanks. @yury-s i can work on this. It's a bit more involved than just adding @inherited. Should have a fix soon.

[uchagani]

Ah ok I understand your use case now. #1515 now also adds @Inherited to the fixture annotation.

[otbe]

True I was more thinking about the abstract super class case. :)
Therefore we would need @inherited I assume based on org.junit.platform.commons.util.AnnotationUtils#findAnnotation(java.lang.reflect.AnnotatedElement, java.lang.Class<A>, boolean, java.util.Set<java.lang.annotation.Annotation>)

[uchagani]

@otbe can your provide an example of what you need working? The example you gave above is working without @inherited after the pull request is merged in.

[otbe]

For example:

@UsePlaywright
public abstract class AbstractBrowserTest {
  // .. some shared test code
}

public class TestFixturesWithNestedClass extends AbstractBrowserTest {

  @Test
  void worksWithOuterClass(Page page) {
    assertNotNull(page);
  }

  @Nested
  class NestedClass {
    @Test
    void worksWithNestedClasses(Page page) {
      assertNotNull(page);
    }

    @Nested
    class DeeplyNestedClass {
      @Test
      void worksWithDeeplyNestedClass(Page page) {
        assertNotNull(page);
      }
    }
  }
}

In our case AbstractBrowserTest has @SpringBootTest, junits @Tag and some shared test code like login(), goToPage(...). I think @Inherited is needed so that AnnotationUtils goes up the tree to our super class.