[Improvement] "Unresolved attribute reference 'stop' for classes SyncPlaywrightContextManager/ AsyncPlaywrightContextManager appears in IDE

[microsoft]

[Improvement] "Unresolved attribute reference 'stop' for classes SyncPlaywrightContextManager/ AsyncPlaywrightContextManager appears in IDE

[mxschmitt]

Could you share with us the exact snippet which is causing that error? And which IDE are you using?

[Igur007]

PyCharm
when to use as:

from playwright import sync_playwright

sync_plw = sync_playwright()
sync_plw.start()

when later is needed to use sync_plw.stop() ---> stop method is not listed by IDE among available methods.

[mxschmitt]

The usage is a bit different, see this example:

from playwright import sync_playwright

playwright = sync_playwright().start()
for browser_type in [playwright.chromium, playwright.firefox, playwright.webkit]:
    browser = browser_type.launch()
    page = browser.newPage()
    page.goto("http://whatsmyuseragent.org/")
    page.screenshot(path=f"example-{browser_type.name}.png")
    browser.close()

playwright.stop()

[Igur007]

thanks, I saw it before creation of this improvement ).

[mxschmitt]

Then I close it okay?

[Igur007]

of course, you can. My purpose was if I can control an instance of a context manager with the start method, why I need to use __exit__ or not obviously defined "stop". Everything works with or without this change.

[mxschmitt]

So we internally start a driver which is basically the upstream github.com/microsoft/playwright project under the hood. In the upstream package the magic happens and in the Python world we only call the Node.js methods internally with a custom JSON based protocol over stdin/stdout.
Thats why we have to start and stop it. Stop is probably not that important but start is needed to use it.