Comments (4)
Could you please open separate issue. This one was explicitly about moving code from TS to C# and adding additional functionality. This item was completed.
Short answer: TS side does not have AST. I guess you are talking about smart indent as in using AST vs relying on regex?
Speaking of Omni, it is not using LSP. They have regular TS extension which then runs their process manually and communicates with it via custom protocol. This is not technically a language server at all. Omni was implemented way before LSP was born.
When actual LS/LSP runs the extension TS/editor part is bypassed and requests go directly to the LS process.
from python-language-server.
Reducing cost to actual for this milestone - basically to the PR review.
from python-language-server.
Finished in #126.
from python-language-server.
Would like to discuss this once again:
- Today indentation of code is implemented within the extension (and buggy, as we do not have the AST information, etc)
- The C# extension supports similar features (indentation changes) when you type the character
}
. - We need the same thing, when users type the character
:
.
The decision was get the extension to do the formatting.
However, if C# extension (using the language server) can do this, they why can't we do the same.
export async function formatAfterKeystroke(server: OmniSharpServer, request: protocol.FormatAfterKeystrokeRequest, token: vscode.CancellationToken) {
https://github.com/OmniSharp/omnisharp-vscode/blob/f0a0336ced8cb44f78bdee88120bfe9d62a596c0/src/omnisharp/utils.ts#L42
Related to microsoft/vscode-python#481
from python-language-server.
Related Issues (20)
- Run Microsoft.Python.LanguageServer standalone encountered a null pointer problem HOT 1
- Dataclass parameters with init=False HOT 2
- Allow language server to be used within markdown code blocks
- Tooltip shows setter docstring instead of GETTER docstring HOT 2
- Unnecessary Semicolon warning (no semicolon in file) HOT 4
- Configure workspace/didChangeConfiguration by default
- Couldn't start client Python Tools. Launching server using command /root/.vscode-server/extensions/ms-python.python-2021.6.944021595/languageServer.0.5.59/Microsoft.Python.LanguageServer failed. HOT 4
- Microsoft Python Language Server cannot be downloaded in WSL
- Error in vscode pylance output: `Stack overflow. Connection to server got closed. Server will not be restarted.` HOT 3
- The Python Tools server crashed 5 times in the last 3 minutes. The server will not be restarted. HOT 1
- Language server extraction failed
- The Python Tools server crashed 5 times in the last 3 minutes. The server will not be restarted. (Stack overflow error) HOT 4
- Can not download python language server HOT 2
- Connection to server got closed. Server will not be restarted. HOT 2
- Duplicate code warnings HOT 1
- Server Crash (Pylance) HOT 1
- Intellisense suggests imported names which should be considered an implementation detail. HOT 1
- opencv-python not autocompleting macos Big Sur using Anaconda, python 3.8.5 HOT 2
- Unable to find document, Object reference not set to an instance of an object HOT 9
- A way to silence 'x' is not accessed HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-language-server.