Support React-Redux V6

[microsoft]

Support React-Redux V6

[abettadapur]

@winklerp Thanks I'll take a look

[abettadapur]

@winklerp Here, I think we can use the ReactReduxContext.Consumer that is exposed, and get the same behavior

[winklerp]

Hi, ReactReduxContext.Consumer works. But since React-Redux 6 supports custom context I think we should pass the context into DynamicModuleLoader and not only rely hard coded on ReactReduxContext.

See release notes of react redux 6.0-beta:

• Passing store as a prop to a connected component is no longer supported. Instead, you may pass a custom context={MyContext} prop to both and . You may also pass {context : MyContext} as an option to connect.

With this it is possible to have several stores in different contexts. So this is why I think passing the context to module loader is necessary. By the way: if we pass a property named store, react redux throws an exception :). Only passing the context works.

[cschleiden]

It's released now.

[abdurahmanus]

Is it ok that I get undefined when I try to access dynamic modules's state ("myModule") when I wrap Lazy component with connect function and use it inside DynamicModuleLoader component? Is't it supposed to have "myModule" to be loaded?

https://codesandbox.io/s/7200w810n6

[abettadapur]

@navneet-g Could you chime in here? I am able to reproduce the problem reported above, but I am not sure why.

I see that the ReactRedux provider context passes store (which has the correct state) and storeState (which does not)

[navneet-g]

@abdurahmanus This is really interesting ... I spent sometime in debugging but did not reach a conclusion, so far it is pointing in direction that it is outside scope of redux dynamic modules and something related to react and react-redux. For example see below screenshot, the _this2.setState actually calls mapStateToProps twice first with old state that does not have myModule state set and immediately after correct state.

[abdurahmanus]

@navneet-g it seems like this behavior was changed somewhere in between v5.1.1 and 6.0.0 of react-redux.
the same example with react-redux v5.1.1 works different way (no undefined value)
https://codesandbox.io/s/xj6l40kjqw
The question is what should be considered as correct behavior? If (while loading process) some module could be undefined it should have nullable type in *AwareState interface (if ts using) and should be checked for undefined value in mapStateToProps or anywere else.

[navneet-g]

If this is a behavior change in react-redux, please open an issue there, we can take it forward then depending upon if they make changes.

[abdurahmanus]

I've also noticed that todo-example uses react-redux@6 and it's broken now

[navneet-g]

I did further debugging and opened following issue in react-redux repo
reduxjs/react-redux#1194

[navneet-g]

This is due to a known change in react-redux with their support to new context API.
reduxjs/react-redux#1126

We need to update DynamicModuleLoader as follows https://codesandbox.io/s/pwmm8r3110
I probably won't have time, if someone wants to make change and send the PR, it would be awesome.