Giter Site home page Giter Site logo

Comments (5)

JiuqingSong avatar JiuqingSong commented on June 2, 2024 1

@gm-al FYI, we will upgrade the roosterjs-react code to be v9 and use new v9 editor in a near future. Although in this change most logic is not changed, but all the code interfaces will be moved to using v9 types.

So if you are still working on the unit test, you may hold on and wait for this v9 change so that your test can target to the new roosterjs-react code.

from roosterjs.

romanisa avatar romanisa commented on June 2, 2024

@gm-al sure please go ahead and our team will be happy to do code review.

from roosterjs.

gm-al avatar gm-al commented on June 2, 2024

I'm working on writing the unit tests for the roosterjs-react, I'm facing some issues related to the webpack config when running tests I wrote for the createPasteOptionPlugin in the pasteOptions folder. When I run npm test I get the following error logs.

An error was thrown in afterAll
  Uncaught Error: Module parse failed: Unexpected token (12:12)
  You may need an appropriate loader to handle this file type, 
   currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
  | import { renderReactComponent } from '../../common/utils/renderReactComponent';
  | import { useTheme } from '@fluentui/react/lib/Theme';
  > import type { LocalizedStrings, UIUtilities } from '../../common/index';
  | import type { Theme } from '@fluentui/react/lib/Theme';
  | import type { PasteOptionButtonKeys, PasteOptionStringKeys } from '../type/PasteOptionStringKeys';

an example of a unit test:

describe('createPasteOptionPlugin', () => {
    let editor: IEditor;
    let plugin: ReactEditorPlugin;

    beforeEach(() => {
        plugin = createPasteOptionPlugin();
        editor = initEditor(div, [plugin]);
        plugin.initialize(editor);
    });

    it('getName', () => {
        expect(plugin.getName()).toEqual('PasteOption');
    });
});

I'm not sure what I'm missing but the webpack.config already handles files with ts extension using ts-loader. Is there new configuration we need to add to handle these TypeScript files with type imports and update the tsconfig? I would appreciate your help on this @JiuqingSong . Thank you!

from roosterjs.

JiuqingSong avatar JiuqingSong commented on June 2, 2024

From the error message, it is complaining the keyword "type". Can you try to remove it?

Currently we didn't force adding "type" import for test code, so we didn't test when adding it if it can pass the build

from roosterjs.

gm-al avatar gm-al commented on June 2, 2024

Yes, actually I did that earlier and got another error but now that I am thinking about it, I think webpack is complaining about the code being imported from the fluentui lib?

  Uncaught Error: Module parse failed: Unexpected token (17:55)
  You may need an appropriate loader to handle this file type, 
  currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
  | import { useTheme } from '@fluentui/react/lib/Theme';
  |
  > const getPasteOptionClassNames = memoizeFunction((theme: Theme) => {
  |     const palette = theme.palette;
  |

from roosterjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.