Comments (2)
Debug shows WriteRunToErrorList is throwing here:
IEnumerable<string> uriBaseIds = dataCache.SarifErrors.Select(x => x.SarifResult?.Locations?.FirstOrDefault()?.PhysicalLocation?.ArtifactLocation?.UriBaseId);
when x.SarifResult is null. Adding a ? gets us past that but then we still have the very odd File/Open dialog with no file name. We can cancel out of that and then we throw here:
Microsoft.Sarif.Viewer.SarifErrorListItem.RemapFilePath(string, string) in SarifErrorListItem.cs Microsoft.Sarif.Viewer.CodeAnalysisResultManager.RemapFilePaths(System.Collections.Generic.IList<Microsoft.Sarif.Viewer.SarifErrorListItem>, System.Collections.Generic.IEnumerable<string>, System.Collections.Generic.IEnumerable<string>) in CodeAnalysisResultManager.cs Microsoft.Sarif.Viewer.ErrorList.ErrorListService.WriteRunToErrorList(Microsoft.CodeAnalysis.Sarif.Run, string, Microsoft.CodeAnalysis.Sarif.SarifLog, out int) in ErrorListService.cs Microsoft.Sarif.Viewer.ErrorList.ErrorListService.ProcessSarifLogAsync(Microsoft.CodeAnalysis.Sarif.SarifLog, string, bool, bool) in ErrorListService.cs Microsoft.Sarif.Viewer.ErrorList.ErrorListService.ProcessLogFileCoreAsync(string, string, bool, bool, bool) in ErrorListService.cs
So my conclusion is this code is having trouble parsing my sarif and not doing a great job of making that clear.
Here's the sarif (again - produced by codeql) that you're failing to parse:
sarif.zip
from sarif-visualstudio-extension.
Here's the repo/branch that the sarif was produced against:
https://github.com/microsoft/mfcmapi/tree/u/sgriffin/codeql
from sarif-visualstudio-extension.
Related Issues (20)
- Fix background color for extension settings HOT 2
- Unhandled exception after opening a folder HOT 1
- Viewer cannot open embedded file content in VS HOT 1
- Compatibility issue referencing Interop DLL HOT 5
- Move common functionalities into a shared place HOT 1
- This repo is missing important files HOT 1
- Visual Studio extension does not have output pane tab for detailed activity and debugging logs HOT 1
- Installer silently fails when attempting to apply to two products, but succeeded when attempted individually. HOT 3
- Investigate clarity of user experience when opening log file HOT 1
- doesn't work on VS 2022 HOT 4
- Per-repo user setting for GHAS integration saved in .vscode/settings.json
- Please remove dependency on C# and VB in the SARIF extension for VS 2022
- Extension output navigation is not intuitive
- Error loading several SARIF logs HOT 1
- Double clicking an error list item when the start of message is the same causes order to scramble
- Double clicking an error list item can cause the corresponding popup to disappear HOT 1
- Opening a folder will not populate sarif error list after the initial open
- Sarif viewer causes crash of VS2022 v17.5.4
- SARIF viewer code finder issue HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sarif-visualstudio-extension.