Giter Site home page Giter Site logo

Comments (6)

gcampbell-msft avatar gcampbell-msft commented on June 8, 2024

Some locations that will help investigate: microsoft/vscode#145234 (comment), microsoft/vscode#209548

from vscode-cmake-tools.

gcampbell-msft avatar gcampbell-msft commented on June 8, 2024

Update on the API: microsoft/vscode#145234 (comment)

from vscode-cmake-tools.

gcampbell-msft avatar gcampbell-msft commented on June 8, 2024

Overall, I think that the main two options for solving the colorized CMake build output is the following:

  1. Improve the syntax textmate that we provide for the CMake/Build output pane.
    1. This is technically already solved through a workaround mentioned here: #478 (comment). This could be added as a dependency or brought in-box to make it easier.
  2. Modify our tasks support (cmake) and our shell integration to use the proposed API here: microsoft/vscode#145234 (comment)
    1. I think that this would include modifying our CustomBuildTaskTerminal class to use the new API.

from vscode-cmake-tools.

gcampbell-msft avatar gcampbell-msft commented on June 8, 2024

Adding reference #2783

from vscode-cmake-tools.

gcampbell-msft avatar gcampbell-msft commented on June 8, 2024

Overall, in response to this comment and adding more context: #3683 (comment).

  1. I don't think there is work to do for the output pane. If people want colorization for their output pane, they will have to do something external either way because of the Output Channel not supporting colors from VS Code. There are currently workarounds for this that currently work for a decent amount of people.
  2. The way that we can provide colorization to users that explicitly want it is through tasks, either manually created by them, or by fixing our tasks support to go through the new Terminal API that is being developed here: microsoft/vscode#145234 (comment)
    1. There is one note to make here, and that is that colorization will happen in the terminal. BUT, there may be additional steps in their CMake project that they need to take either way, in order to get colorization to happen. https://cmake.org/cmake/help/latest/variable/CMAKE_COLOR_DIAGNOSTICS.html, https://stackoverflow.com/questions/9963783/how-can-i-configure-cmake-to-generate-a-buildsystem-that-emits-colored-errors-an, etc.

from vscode-cmake-tools.

gcampbell-msft avatar gcampbell-msft commented on June 8, 2024

I've done minimal testing and chatting with the maintainers here microsoft/vscode#145234 (comment), and while it's not EXACTLY what we want in terms of a simple async-await pattern for invoking a command and getting the exit code, we can definitely use the API to do what we want. Therefore, this API, once officially supported/released, can be used for our task support and we should be able to provide an officially supported way to route tasks (or build) to a terminal and have colorization (assuming their project is set up for colorization in the terminal).

@sinemakinci1 @microsoft/vscode-cmake FYI.

from vscode-cmake-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.