Optionally enable go-metalinter support?

[NHOrus]

Optionally enable go-metalinter support?

[lukehoban]

Sounds like a great idea.

Should be easy to add support for that either as the default linter or as an option to use instead of discreet lint/vet.

[lukehoban]

Open to PR's adding support for this.

I'd suggest adding a go.lintTool setting that can optionally point to an alternate tool to run instead of golint. That would allow users to opt-in to using gometalinter once they have installed and configured it.

A further step would be to make it the default. I think we should wait on that, since the acquisition experience for gometalinter is incrementally more complex.

[joeblew99]

this would be awesome !

[gobijan]

I came here because I wanted to propose support for https://github.com/alecthomas/gometalinter, too :)
Atoms Go Plugin and SublimeText have support for this. Maybe one could have a look at the Atom implementation for adding support to vscode (are the APIs similar because of the electron shell?): https://atom.io/packages/gometalinter-linter

[sijad]

@lukehoban output of golint and gometalinter are a little different, with current regex can't parse gometalinter output

[lukehoban]

@sijad Feel free to propose an update to the regexp to make sure gometalinter output can be handled.

[johansja]

There is an PR for this.Wondering what is the progress on that? @sijad @lukehoban

[punya]

gometalinter can also produce JSON output, if that makes parsing easier.

[joeblew99]

@lukehoban JSON parsing helps ?
I am keen to get this into VSCode :)

[egamma]

I suggest to look into how some of the existing linters are implemented for VS Code. ESLint is a good example vscode-eslint, tslint, and jshint are implemented in the same way. The idea is to implement a linter as a language server. The language server is kept a live and receives buffer change requests from VS Code (over JSON RPC), runs the linter (in proc) on the changed buffer, and returns the errors diagnostics back to VS Code. Doing the linting inside a server avoids that a new process is restarted for each validation as the user types.

[sijad]

#294 is almost finished, it just need a review I guess

[egamma]

Nice. This implementation spawns a new process for each linting pass. Since the linter is native code and since this is only done on save this might not be too bad for the batteries.

[mattetti]

This issue can be closed now that the feature is implemented and documented :)

[lukehoban]

Indeed. Thanks @sijad.