Giter Site home page Giter Site logo

Comments (9)

RMacfarlane avatar RMacfarlane commented on May 18, 2024 1

@baelter @osya Thanks for reporting and the clear steps to reproduce! There was an issue with caching that I just checked in a fix for. The extension maintains a cache for excludes that was correctly being cleared when the ignore file updated, but there was also a cache being maintained by a parsing library that didn't ever get reset. I'll publish a new version of the extension soon.

from vscode-jshint.

osya avatar osya commented on May 18, 2024 1

@RMacfarlane , sorry. It works. I just added the content **/*.jsx to the file .jshintignore and then jshint begins ignoring *.jsx files. Empty file .jshintignore with the user setting

"jshint.exclude": {
    "**/*.jsx": true
},

does not ignore *.jsx files. It seems it is correct

from vscode-jshint.

kieferrm avatar kieferrm commented on May 18, 2024

Started development in https://github.com/Microsoft/vscode-jshint/tree/feature/jshintignore.

from vscode-jshint.

kieferrm avatar kieferrm commented on May 18, 2024

Closed with 49b9258.

from vscode-jshint.

baelter avatar baelter commented on May 18, 2024

Can't get this to work,

Putting

**/*

in .jshintignore and all files are linted.

vscode: 1.21.1
vscode-jshint: 0.10.17
jshint: 2.9.5

from vscode-jshint.

osya avatar osya commented on May 18, 2024

@baelter , confirm that .jshintignore support in vscode-jshint is not worked as expected.

Projects structure:

  • app - src - index.jsx

Step to reproduce

  1. Add to user settings
"jshint.exclude": {
    "**/*.jsx": true
},

index.jsx for jshint ignored. It is as expected
2. Add an empty file .jshintignore to the project root and restart VS Code
index.jsx for jshint is NOT igored. It is a bug
3. Add src/** in the .jshintignore file and restart VS Code
index.jsx is ignored in PyCharm - so .jshintignore is correct. In VS Code index.jsx for jshint is NOT igored. It is a bug
4. Remove jshint.exclude from user settings and restart VS Code
index.jsx for jshint is NOT igored. It is a bug

vscode: 1.23.1
vscode-jshint: 0.10.18
jshint: 2.9.5

from vscode-jshint.

RMacfarlane avatar RMacfarlane commented on May 18, 2024

@baelter @osya Just published a new version of the extension. Please give it a try

from vscode-jshint.

osya avatar osya commented on May 18, 2024

@RMacfarlane , thank you for your attention. I just checked. But the issue still exists.

vscode: 1.24.0
vscode-jshint: 0.10.19
jshint: 2.9.5

from vscode-jshint.

RMacfarlane avatar RMacfarlane commented on May 18, 2024

@osya Hmm, I've tried your steps above with the versions you listed and it works for me. Could you share your settings?

from vscode-jshint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.