Comments (5)
Apparently, the "wix" installerType is actually for WiX MSIs. When the WiX toolset is used to create an exe, that's actually a "burn" installer. https://wixtoolset.org/documentation/manual/v3/bundle/
burn did indeed solve the EA Desktop InstallerType, hope there is a easy way to detect the difference between burn and WiX MSI :)
from winget-create.
Very strange indeed. From the exe manifest, this does seem to be a WiX installer:
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<assemblyIdentity name="setup.exe" version="1.0.0.0" processorArchitecture="x86" type="win32"/>
<description>WiX Toolset Bootstrapper</description>
However, winget fails when trying to install it as such. Changing wix to exe in the installer manifest seems to fix the issue. It's possible either this is an extremely rare edge case where the workaround of manually editing the manifest is sufficient, or it's possible there's something wrong with our installerType detection heuristic.
from winget-create.
EA Desktop also does the same
https://origin-a.akamaihd.net/EA-Desktop-Client-Download/installer-releases/EADesktopInstaller.exe
But i do believe the EULA switch works, so it IS a wix installer, however when i have the InstallerType: wix
and the Silent parameter /silent which "works(?)" the installer comes with a error..
I don't know how installers work, but do they disable the parms for some wild reason?
from winget-create.
Apparently, the "wix" installerType is actually for WiX MSIs. When the WiX toolset is used to create an exe, that's actually a "burn" installer. https://wixtoolset.org/documentation/manual/v3/bundle/
from winget-create.
We decided to just set the installerType for all MSIs as "msi" for now. Winget itself doesn't treat them differently: https://github.com/microsoft/winget-cli/blob/cf6f8e58195bf033a1a5872f7b800866cd27a586/src/AppInstallerCommonCore/Manifest/ManifestCommon.cpp#L348. If that ever changes, we'll re-evaluate
from winget-create.
Related Issues (20)
- Root Level overwrites Installer Level Incorrectly
- "ERROR: Path does not exist" when using trailing \ on manifest path (submit) HOT 4
- Progress bar when downloading installer HOT 1
- Architecture specific `update` doesn't work HOT 2
- [Bug report] Unable to inspect MSIX file HOT 2
- `wingetcreate update` based on GitHub release
- Crash when attempting to submit a manifest HOT 1
- Bug - Fork Sync Issue HOT 8
- `wingetcreate update` / `wingetcreate update -i` Installer version problem HOT 5
- wingetcreate update confuses argument for --submit in PS script HOT 2
- Cannot update manifest with additional installers HOT 3
- Support .tar.gz archives HOT 2
- Ability to update DisplayVersion in autonomous update HOT 2
- Add support for removing manifests HOT 2
- Support object input for overrides HOT 1
- `Octokit.ApiException` error when creating pull request
- wingetcreate does not update upgrade code
- wingetcreate does not update product code and upgrade code when they are present inside ARP Entries HOT 3
- zip Sha256 hash problem HOT 4
- Cannot update if name of EXE file has changed inside ZIP
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from winget-create.