Comments (7)
WingetCreate uses the architecture field (along with others if present) to find a suitable installer match for update from the previous manifest. When it cannot determine the architecture of the new installer from the URL (it looks for specific keywords like x64, x86, 32-bit etc), it tries to scan the installer binary to determine its arch.
It's known that Inno is an x86 application, so inno installers are usually x86 irrespective of the architecture of the application it installs. What's happening here is that since the previous / base manifest contains a single installer node of x64 arch, WingetCreate tries to find a new URL from the command you've written that can match this installer node in the update. It cannot determine the arch from URL, so falls back to using binary architecture which happens to be x86 and due to this arch mismatch, WingetCreate fails to update the package.
An easy fix here is you can override this behavior and explicitly tell WingetCreate what architecture you would like to target by appending it at the end of the URL. You can use this command to update your package:
wingetcreate update tecwindow.SoundTranscriber --version 1.3.0 --urls "https://github.com/tecwindow/SoundTranscriber/releases/download/V1.3.0/SoundTranscriberV1.3.0.exe|x64"
from winget-create.
WingetCreate uses the architecture field (along with others if present) to find a suitable installer match for update from the previous manifest. When it cannot determine the architecture of the new installer from the URL (it looks for specific keywords like x64, x86, 32-bit etc), it tries to scan the installer binary to determine its arch.
It's known that Inno is an x86 application, so inno installers are usually x86 irrespective of the architecture of the application it installs. What's happening here is that since the previous / base manifest contains a single installer node of x64 arch, WingetCreate tries to find a new URL from the command you've written that can match this installer node in the update. It cannot determine the arch from URL, so falls back to using binary architecture which happens to be x86 and due to this arch mismatch, WingetCreate fails to update the package.
An easy fix here is you can override this behavior and explicitly tell WingetCreate what architecture you would like to target by appending it at the end of the URL. You can use this command to update your package:
wingetcreate update tecwindow.SoundTranscriber --version 1.3.0 --urls "https://github.com/tecwindow/SoundTranscriber/releases/download/V1.3.0/SoundTranscriberV1.3.0.exe|x64"
This indeed works. The manifest files have been successfully downloaded and updated. Thank you for your assistance.
I hesitated to open issues for something as straightforward as this, but the winget docs lack clear examples or documentation for such issues. They also do not specify the correct way to write commands.
There's one more thing: I submitted pull requests to winget three days ago or more, and they haven't been approved yet. Is this normal?
from winget-create.
WingetCreate uses the architecture field (along with others if present) to find a suitable installer match for update from the previous manifest. When it cannot determine the architecture of the new installer from the URL (it looks for specific keywords like x64, x86, 32-bit etc), it tries to scan the installer binary to determine its arch.
It's known that Inno is an x86 application, so inno installers are usually x86 irrespective of the architecture of the application it installs. What's happening here is that since the previous / base manifest contains a single installer node of x64 arch, WingetCreate tries to find a new URL from the command you've written that can match this installer node in the update. It cannot determine the arch from URL, so falls back to using binary architecture which happens to be x86 and due to this arch mismatch, WingetCreate fails to update the package.
An easy fix here is you can override this behavior and explicitly tell WingetCreate what architecture you would like to target by appending it at the end of the URL. You can use this command to update your package:wingetcreate update tecwindow.SoundTranscriber --version 1.3.0 --urls "https://github.com/tecwindow/SoundTranscriber/releases/download/V1.3.0/SoundTranscriberV1.3.0.exe|x64"
This indeed works. The manifest files have been successfully downloaded and updated. Thank you for your assistance.
I hesitated to open issues for something as straightforward as this, but the winget docs lack clear examples or documentation for such issues. They also do not specify the correct way to write commands.
There's one more thing: I submitted pull requests to winget three days ago or more, and they haven't been approved yet. Is this normal?
Thanks for calling this out, we need to work on updating the docs to make it more clear on what the best course of action is if these errors are encountered.
Regarding your PR, it should have been checked in or at least reviewed. It takes a couple hours to go through our validation pipeline and a couple days for one of our moderators to approve it (Maybe a bit more given the timing of the holidays π¦ ). Any errors that appear or feedback from our moderators need to be address before your manifests get checked in.
from winget-create.
Regarding your PR, it should have been checked in or at least reviewed. It takes a couple hours to go through our validation pipeline and a couple days for one of our moderators to approve it (Maybe a bit more given the timing of the holidays π¦ ). Any errors that appear or feedback from our moderators need to be address before your manifests get checked in.
ChatGPT
"This topic is frustrating for me. Some programs submitted just minutes ago, like this one:
were immediately approved. Meanwhile, my program, launched three days ago, has yet to receive approval:
What mechanism is being relied upon in this process?"
from winget-create.
It was accepted 2 hours ago....
from winget-create.
It was accepted 2 hours ago....
"Yes, my program was approved immediately after being mentioned here."
from winget-create.
@MesterPerfect; The community moderators over at winget-pkgs are all volunteers. Often times we, like the MSFT engineers, get busy with family or friends on the weekends, or have limited amout of time throughout the day to do reviews - sometimes its 20 minutes here, 30 minutes there, 15 minutes between other things going on, its not always an hour or two of concentrated time. A common practice is to start with the "easy" reviews or the PRs related to well-known packages and then work through the ones that remain. This is why some packages take only a few hours to be reviewed (Chrome, Firefox, and Git, for example, all make it past my email filter) and others take longer. Add onto that the fact that some packages need a MSFT employee to look at them and add a waiver, it all adds up quickly.
Specific to your PR, I see a few reasons why it took 3 days to be reviewed -
- It was submitted on Friday, and many moderators have limited availability on weekends
- It is not for a well known package which is relied upon by many users
- The PR history isn't clean; There was the unattended install issue, and 3 commits that donβt have descriptive messages. This means that a moderator needs to spend more time checking the install and verifying the content. One suggestion would be to use commit messages like "Fixed Installer Architecture" or "Updated Dependencies" to make it easier to understand why the changes fixed the issues and gives confidence that they wonβt re-appear in unique environments.
from winget-create.
Related Issues (20)
- [Feature Request] Support Qt Installer Framework HOT 2
- Root Level overwrites Installer Level Incorrectly
- "ERROR: Path does not exist" when using trailing \ on manifest path (submit) HOT 4
- Progress bar when downloading installer HOT 1
- Architecture specific `update` doesn't work HOT 2
- [Bug report] Unable to inspect MSIX file HOT 2
- `wingetcreate update` based on GitHub release
- Crash when attempting to submit a manifest HOT 1
- Bug - Fork Sync Issue HOT 8
- `wingetcreate update` / `wingetcreate update -i` Installer version problem HOT 5
- wingetcreate update confuses argument for --submit in PS script HOT 2
- Cannot update manifest with additional installers HOT 3
- Support .tar.gz archives HOT 2
- Ability to update DisplayVersion in autonomous update HOT 2
- Add support for removing manifests HOT 2
- Support object input for overrides HOT 1
- `Octokit.ApiException` error when creating pull request
- wingetcreate does not update upgrade code
- wingetcreate does not update product code inside ARP Entries HOT 3
- zip Sha256 hash problem HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from winget-create.