Images still not loading!

[middlebury]

Images still not loading!

[adamfranco]

Thanks for kind words @saadsm!

4fe647a fixed an issue (reported in #31 and #28) that was totally preventing images from loading correctly in all cases (including new Moodle installations).

Your report in this issue and @dheuring's comments on #31 indicate that the 4fe647a fix didn't resolve all image-loading issues in some already-existing Moodle installations, though it did for new Moodle installations. My hunch is that there is something going on in some existing Moodle installations that is changing file URLs in a way that they don't change in a fresh installation. Maybe it is caused by a plugin folks are enabling or maybe there are internal file and file-usage ids that normally increment in parallel, but aren't guaranteed to.

Unfortunately I'm not able to replicate this issue on my own installation of Moodle. Additionally my institution is moving away from Moodle and while I'm happy to review patches & Pull Requests, I'm not able devote significant time to tracking down issues in this module. If you or others in the community are able to track down the cause of the issue (or even better provide a fix), I'd be happy to put in in place and package a new release.

[adamfranco]

The MOODLE_31 branch now includes a patch #55 from @semteacher that makes changes to image access. Please test the new code and report if it fixes your issue.

[dheuring]

I tested this latest version of adaptivequiz on my development server Moodle 3.4+. Unfortunately, it has not resolved the image-loading problem I've had for quite some time now. Same problem as reported above where the image shows when editing, but not when running the test. I've used the same work-around as saadsm by placing my images and audio files in a directory outside of Moodle and linking to them. Life goes on....

[Andmat7]

The bug is on the line 694 from file lib.php , The course module is being obtained with the course id instead of a course module id, I temporarily solved the bug commented the lines 694 to 697 and 704 to 718 from lib.php

[adamfranco]

Thanks for that tip, @Andmat7. If you or anyone else is able to provide a PR with a full fix, that would be great.

[semteacher]

I have investigated an issue that @Andmat7 found. As I understand he is right - there is no correct coursemodule instance info there. As I compared to conventional quiz - they get $cm only from attempt.
However - there is no such method in this module.
So, I decide to retrieve all necessary fields directly using existing info. And got some success. Images now have been loaded for me... Notice: was lack of testing - I have had not enough ADPQ quizzes instances (Actually, I do this job "just for fun" - I am no longer involved in project were ADPQ module was used).
I have opened pull request with this fix.

[adamfranco]

Thank you for submitting this issue. This repository is now archived: The sponsor of this plugin, Middlebury College, is no longer using Moodle. Development is continuing on other forks of the project. See https://moodle.org/plugins/mod_adaptivequiz for more information and latest releases.