Comments (6)
Hmm, this gets tricky when testing. If jindw/xmldom
is not installed the tests will fail.
maybe this middleware should reside in its own repo instead?
like middyjs/middy-middleware-xml-body-parser
?
alternative: we make jindw/xmldom
a dependency of this repo?
from middy.
Sure, that would be great!
from middy.
It's definitely a good point to move middlewares to external packages. Anyway I don't want to overcomplicate the project in this initial phase, so I am ok for now to have jindw/xmldom
as a dependency of this project.
When we'll be ready to release 1.0.0
maybe we can reconsider this assumption and decide whether it makes sense or not to move middlewares outside the core.
from middy.
Hey @philipodev, are you still working on xml support?
from middy.
@philipodev Is there still a need for this? We'd be happy to have an xmlBodyParser
middleware if you'd like to make a PR to the v1 branch.
from middy.
Please submit a PR if you're still interested in adding this functionality in.
from middy.
Related Issues (20)
- Streamed responses giving 502 Bad Gateway when payload exceeds threshold (25kb+) HOT 8
- How to use version 5 with TypeScript HOT 4
- http-response-serializer documentation incorrect HOT 1
- Typescript error in handler parameters HOT 4
- Module not found: Error: Package path . is not exported from package HOT 1
- Response validation not working HOT 4
- Use @fastify/busboy instead of outdated busboy HOT 2
- Type middy.MiddlewareFn doesn't exist HOT 17
- Cannot find module '@middy/core' when running jest with typescript and esm HOT 15
- ERR_PACKAGE_PATH_NOT_EXPORTED HOT 2
- @middy/dynamodb middleware: Unmarshall on empty item is causing exception HOT 3
- The `inputOutputLogger` middleware fails if used with a streaming handler. HOT 2
- Matching `Access-Control-Allow-Headers` HOT 5
- Documentation: Enable middlewares based on request event parameters HOT 3
- Http router / path mapping HOT 6
- Not able to invoke the http-router routes from post-man using serverless-offiline HOT 4
- ERR_PACKAGE_PATH_NOT_EXPORTED error HOT 1
- index.d.ts still allows callback based handlers.
- dead links on getting started page HOT 1
- [middy/core] get event input in timeoutEarlyResponse parameter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from middy.