Giter Site home page Giter Site logo

XML Body Parser about middy HOT 6 CLOSED

middyjs avatar middyjs commented on April 28, 2024
XML Body Parser

from middy.

Comments (6)

philipodev avatar philipodev commented on April 28, 2024 1

Hmm, this gets tricky when testing. If jindw/xmldom is not installed the tests will fail.
maybe this middleware should reside in its own repo instead?
like middyjs/middy-middleware-xml-body-parser?

alternative: we make jindw/xmldom a dependency of this repo?

from middy.

lmammino avatar lmammino commented on April 28, 2024

Sure, that would be great!

from middy.

lmammino avatar lmammino commented on April 28, 2024

It's definitely a good point to move middlewares to external packages. Anyway I don't want to overcomplicate the project in this initial phase, so I am ok for now to have jindw/xmldom as a dependency of this project.

When we'll be ready to release 1.0.0 maybe we can reconsider this assumption and decide whether it makes sense or not to move middlewares outside the core.

from middy.

lmammino avatar lmammino commented on April 28, 2024

Hey @philipodev, are you still working on xml support?

from middy.

willfarrell avatar willfarrell commented on April 28, 2024

@philipodev Is there still a need for this? We'd be happy to have an xmlBodyParser middleware if you'd like to make a PR to the v1 branch.

from middy.

willfarrell avatar willfarrell commented on April 28, 2024

Please submit a PR if you're still interested in adding this functionality in.

from middy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.