Improve CORS middleware to support other CORS headers

[middyjs]

Improve CORS middleware to support other CORS headers

[akshitgrover]

@lmammino can I work on this?

[lmammino]

Sure thing @akshitgrover

[abdullateef97]

can i work on this
#38

[lmammino]

@akshitgrover, what's the current status? Do you want to coordinate/pair with @abdullateef97?

[abdullateef97]

please do let me know if i can proceed

[abdullateef97]

@lmammino can i

[lmammino]

@abdullateef97 go ahead for now ;)

[akshitgrover]

Sorry, I was stuck with something. Maybe I can help if work is still not done? @lmammino @abdullateef97

[lmammino]

I would be happy for this to be a collaborative effort between @akshitgrover and @abdullateef97 . Can you discuss this between yourself and figure out how to collaborate?

If you need a discussion channel, you can join the middy official chat on gitter: https://gitter.im/middyjs .

Once you have a first PR, I will be happy to support the process with a formal reviews and advices if needed.

[akshitgrover]

I am working on Access-Control-Max-Age. @lmammino @abdullateef97

[abdullateef97]

@lmammino ive u tried using the cors middleware, if you have what were the issues

[akshitgrover]

@lmammino I am not able to run the tests, It is not returning undefined instead of objects.

[lmammino]

@abdullateef97 @akshitgrover I am not sure what are you trying to do. Please join the gitter chat where I guess it would be easier to discuss interactively your issues.

[omry-hay]

@lmammino - Are you going to add the following any time soon?

• Access-Control-Max-Age
• Access-Control-Allow-Methods

[camiloaz]

I see this issue is closed but there is no solution yet if you want to be able to set the Access-Control-Allow-Methods header.

[willfarrell]

It's been added to v2, see release/2.x branch