Navigation "lost" when going from talk to planning

[mielpopscrew]

Navigation "lost" when going from talk to planning

[omnisnash]

Hi, thanks for your feedback !

Concerning the scrolls, the issue is global to the application. I will try to use the solution from angular/angular#10929 (comment)

The tabs now... One possible solution is to use the route system : for example, /schedule/friday to keep a trace of the last selected tab in the browser history. But if you play to much with tabs, you will have to press 'back' serveral times before reaching another app section :/

Any opinions ?

[xballoy]

I agree with you, if everytime we change tab we add something in the browser history we will have a strange behaviour.

However, why not pushing the current schedule route in the history only when the user navigate to the detail?

[omnisnash]

In fact, pushing the current route in the history is handled by Angular itself, and I don't think it's possible to change the behavior.

I will test this :

• Creating a service to store navigation states (like schedule tab index)
• Adding a subscription to the Angular Location service in the Schedule component to track if the back button was pressed
• Retrieved the tab index from the navigation state service

[omnisnash]

These problems are now partially solved:

The tab index is saved when navigating back/next in bookmark/schedule.

Concerning the scroll restoration, it works... Only on mobile view (when navigation menu is hidden). I don't know why, the scroll position isn't restored on desktop view. Maybe something relative to media-query ? (cc @leodonny ).

You can test this behavior on the bugfix/#7-navigation_lost branch

Should we consider embedded these corrections into the next release, even it's not working on desktop view ?

[xballoy]

Maybe we can split the issue in two:

• the navigation issue: ✅
• the scroll issue

If the navigation issue is solved we can ship it IMO

[omnisnash]

I agree, see #16 .