Profile dialog for other users too big for low resolution screen

[miguelfreitas]

Profile dialog for other users too big for low resolution screen

[dionyziz]

You can close the modal by clicking on the dark background. Please git pull, this is in one of the latest patches.

You're right, this is not optimal usability. We should look into adapting modal size to screen resolution and work towards adopting a more flexible user interface.

[toyg]

@dionyziz should we close this for now then?

[dionyziz]

No, let's keep it open. It's a bug that needs to be addressed.

[BlockTester]

@dionyziz +1

[BlockTester]

I don't seem to have the patch for clicking the background (or 'esc'?), could we merge this to the master?

[toyg]

I think that patch was reverted because it was giving problems in some places.

[rbertoche]

Would that "click away to close" patch solve this? Or it would be too ugly?

[BlockTester]

@rbertoche no it's the proper solution and esc key should also be added, but as mentioned the patch was reverted as it caused some other bug, another patch needs to be written or the bug ironed out.

[toyg]

ok, previews of what the modal looks like after my fixes... note that the modal is now positioned from the top of the screen, so the top bar will always be visible regardless of resolution. The "Posts" number has actually been pushed to the right like it appears in the "single line" screenshot, I just couldn't be bothered to re-take the others...

Full profile:

Two lines:

Single line:

No image:

[iShift]

IMHO, we need full page for profiles not only modal windows and on small screen we can show full profile pages

[toyg]

That's a good point. However, one issue with fullscreen profiles is navigational speed/usability... Because of postboard/post sync not working properly, most people are currently forced to check profiles one by one to see recent messages. If each profile is a page refresh, it takes twice the time, and you also have to think about a new solution for navigation from one profile to the next. I just wouldn't do it until the timeline bug is fixed; I'd rather somebody approximated the effect by reworking following.html, which tbh has to be done anyway.

The idea behind this change was just to make the current modal a bit more flexible, allowing people with smaller screens to actually close it. I'd merge this as a bug fix, waiting for more substantial changes further down the line (this is just playing with CSS, really). But I'm waiting for @miguelfreitas to sanction it :)

[BlockTester]

@toyg 👍 good stuff! I didn't test it yet but from the screenshots it's very nice :)

@iShift different issue.

[rbertoche]

I looked at your patch. It's really looking nice -except for me hater of radius at photos- and far more compact.

Can't get this random padding off from the bottom of the modal, though. That's why it was done with absolute pixel sizing - which was worse. As both their height are set in percentages of the page, postboard and it's scrollbar can't follow modal borders correctly upon window resize.
Sometimes the postboard's larger than the dialog and hides partially, or instead a white padding is seen at the bottom. It would be marvelous to be able to use a percentage of the parent div, instead of the entire page.

Is it really impossible to allow overflow handling without having to set height? To somehow use all avaiable space from another div that has a set height?
I'm almost suggesting css edition from js - setting heights inside the modal based on page size in pixels.

[rbertoche]

I tried a bit, messed with a lot of code, but only got to move the padding to another place. Though it got really nice on a 600px tall window, on a 1000px> it looks like a gargoyle.

The only real gain was that now it can't hide any texts, at any window height.

The idea was to get 2 separated "modal dialogs". That way the second one has height and overflow: auto.
I forked and pushed to my clone on github, if you wanna take a look.