TWI::Slave broken

[dothebart]

TWI::Slave broken

[mikaelpatel]

After reviewing the changes after the low power support the issue seems to be the missing powerup() in TWI::Slave::begin.

[dhillondeep]

@Mogball you can add those modules if you want rn. I will add some when I have more time

[dhillondeep]

@Mogball We had this issue as well rmr

[dhillondeep]

@shahzadlone tried to fix the commit 173c3eb and he made changes committed here on this commit.

void
TWI::isr_stop(State state, uint8_t type)
{
  TWCR = TWI::STOP_CMD;
  loop_until_bit_is_clear(TWCR, TWSTO);
  if (UNLIKELY(state == TWI::ERROR_STATE)) m_count = -1;
  m_state = state;

  // Check for asynchronous mode and call completion callback
  if (m_dev->is_async() || m_status == SR_STOP) {
    m_dev->on_completion(type, m_count);
    // m_dev = NULL;
    m_busy = false;
    // TWCR = 0;
  }
}

This seems to fix the issue and the slave starts to work but, slave breaks again on the commit a0d6795 where support for low power mode was improved. Can you suggest what we should look into for a potential fix?

[shahzadlone]

You are right @mikaelpatel that seemed to have fixed it. I will be putting all these bug fixes in and then open a pull request.

[dhillondeep]

@dothebart I do not think there is such a list. So I ended up creating a list and you can add to it https://github.com/dhillondeep/cosa-projects

[Mogball]

What about our sensor modules? :P not just our build tools

[mikaelpatel]

Yes, the update to the TWI event handling has broken the TWI::Slave implementation. Busy right now but should get time to check the details in a few weeks. Thanks for the reporting.

[Mogball]

Yeah we aren't to receive events either

[mikaelpatel]

Please see commit 2b07bd6.

[dothebart]

btw, is there a list of opensource projects using cosa? Probably @dhillondeep could add an item to it? ;-)

[shahzadlone]

This should now be fixed.