Giter Site home page Giter Site logo

Comments (1)

hughbris avatar hughbris commented on May 23, 2024

The other problems with retrieving the default number of posts and then slicing them in the template are:

  • if the results contain mostly posts without message properties, most of the posts will be eliminated and users may be served less posts than the count setting. For example, if the FB API returns 25 posts, count is set to 15, and 13 posts are discarded because they have no message property, users will only see 12 posts rather than 15, even though more are available. This is a bug.
  • more posts are retrieved from the API than required.

So this is a good change in my opinion, even though handling/rendering the different post types is more complex than we'd like. However, it would be a somewhat "breaking" change without accommodating each post type properly in default templates etc.

from grav-plugin-facebook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.