Giter Site home page Giter Site logo

Comments (15)

mike-lischke avatar mike-lischke commented on June 9, 2024 1

That would be great news! This (just fixed) issue looks very much like the problems here. Unfortunately, this project neither releases packages nor bundles, so it's tricky to know when a new release comes out (if they even make releases).

from vscode-antlr4.

mike-lischke avatar mike-lischke commented on June 9, 2024 1

Yes, I will update the library, but I'm pretty busy with other stuff. Need to find some time for it...

from vscode-antlr4.

mike-lischke avatar mike-lischke commented on June 9, 2024

IIRC this is not only a problem for the last rule. I have seen this also for rules in the middle somewhere. Last time I looked it was so that the railroad library did not correctly compute the total height of the diagram. Needs investigation, but your proposal would only fix a part of the problem.

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

Do you have an example about rules in the middle somewhere? If not can you put them later?

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

I found something interesting. You build tab with next structure.

  1. semitransparent header with g4 info:
    image

  2. You have a container with rail structure:
    image

In 2 you use a property with name "padding" that has a parameter "60px". This has incorrect influence to "height:100vh" (100vh do not enlarge on 60px):
(example: https://css-tricks.com/almanac/properties/p/padding/#aa-padding-and-element-width-calculations)

image

To fix this I found a property "box-sizing: border-box":
image

Now all looks good: first element is not under a header and a last element is not hidden. What do you think?

info of a box-sizing:

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

that the railroad library did not correctly compute the total height of the diagram

Now I think that this railroad issue is another issue.

from vscode-antlr4.

mike-lischke avatar mike-lischke commented on June 9, 2024

My assumption was that the missing space at the end is the same problem like missing space in the middle of the document:

Bildschirmfoto 2024-02-13 um 09 30 01

But you might have a point in your analysis of other spacing and the boxing model. I'll have to investigate.

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

Can you give me this example? Or send it by email [email protected] ? I promise not to show anyone.

from vscode-antlr4.

mike-lischke avatar mike-lischke commented on June 9, 2024

It's open source like everything I do on Github 😄

Note also the other display problems like in alterListItem:

Bildschirmfoto 2024-02-13 um 09 57 47

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

I'm sorry I found MySQLParser.g4 file with another syntax. Now I use your grammar. Can you show your extension settings?

from vscode-antlr4.

mike-lischke avatar mike-lischke commented on June 9, 2024

It probably doesn't make a difference, but here they are:

    "antlr4.rrd.saveDir": "/Users/Mike/Desktop/rrd",
    "antlr4.atn.saveDir": "",
    "antlr4.atn.maxLabelCount": 10,
    "antlr4.call-graph.saveDir": "/tmp/",
    "antlr4.debug": {
        "visualParseTreeHorizontal": true,
        "visualParseTreeClustered": true
    },
    "antlr4.generation": {
        "mode": "internal",
        "listeners": true,
        "visitors": false,
        "outputDir": "./generated"
    },
    "antlr4.format": {
        "disabled": false,
        "alignTrailingComments": true,
        "allowShortBlocksOnASingleLine": true,
        "breakBeforeBraces": false,
        "columnLimit": 150,
        "continuationIndentWidth": 4,
        "indentWidth": 4,
        "keepEmptyLinesAtTheStartOfBlocks": false,
        "maxEmptyLinesToKeep": 1,
        "reflowComments": false,
        "spaceBeforeAssignmentOperators": true,
        "tabWidth": 4,
        "useTab": false,
        "alignColons": "none",
        "singleLineOverrulesHangingColon": false,
        "allowShortRulesOnASingleLine": false,
        "alignSemicolons": "ownLine",
        "breakBeforeParens": false,
        "ruleInternalsOnSingleLine": false,
        "minEmptyLines": 1,
        "groupedAlignments": true,
        "alignFirstTokens": true,
        "alignLexerCommands": false,
        "alignActions": false,
        "alignLabels": true,
        "alignTrailers": false
    },

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

At last I got these errors after settings:
image

Nice:
image

)))

from vscode-antlr4.

mike-lischke avatar mike-lischke commented on June 9, 2024

Yes, that's the setting for wrapping long sequence lines in the diagram. Of course, if no wrapping occurs then the display is fine. IMO the RRD script does not fully cover some of the cases we use in these diagrams.

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

I found something - version of railroad.js file in this repo is too old. I try last (newest) version and all look good:

https://github.com/tabatkins/railroad-diagrams/blob/gh-pages/railroad.js
image

and all look good

image

I use setting "wrapAfter"=60.

from vscode-antlr4.

satabol avatar satabol commented on June 9, 2024

Happy to help you. I just compare count of lines of code. Intuition. ))) Are you planning to update this library?

from vscode-antlr4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.