Giter Site home page Giter Site logo

Comments (4)

themightychris avatar themightychris commented on July 1, 2024

This seems to be related to jsDAV not returning a list of 404'd properties in response to PROPFIND requests. I spent some time debugging handler.js and the correct 404 properties list seems to be getting defeated at several layers.

The bit of code SabreDAV uses to fill up 404's when the property doesn't match any of its handlers: https://github.com/evert/SabreDAV/blob/master/lib/Sabre/DAV/Server.php#L1588

is inverted and put somewhere that never gets called for not found properties: https://github.com/mikedeboer/jsDAV/blob/master/lib/DAV/handler.js#L1571

I tried fixing that but then one of the listeners being executed between https://github.com/mikedeboer/jsDAV/blob/master/lib/DAV/handler.js#L1576 and the first line of the callback immediately following seems to be clearing out the 404 object's properties.

Finally, jsDAV_Property_Response.serialize doesn't seem to be prepared to render the empty 404 property nodes.

Am I completely missing something or did PROPFINDS never return 404s entries?

from jsdav.

mikedeboer avatar mikedeboer commented on July 1, 2024

Thanks for helping me debug this! You are right, the 404 handling in jsDAV is wrong. I will try to debug this asap and will update you with the progress!

from jsdav.

themightychris avatar themightychris commented on July 1, 2024

Thanks Mike, I don't mean to push but could you let me know if this is something you'll get to in the next week or two? I'm sure that you'll find a more holistic solution than I could, but this bug is holding up my project (porting my app from SabreDAV) so I might see what I can come up with on my own if it will be more than a week or so before you can dig in. I don't want to duplicate your work though if you have an approach in mind already.

from jsdav.

mikedeboer avatar mikedeboer commented on July 1, 2024

jsDAV has changed A LOT in two months. Current release is v0.3.0. Closing this issue, because this behavior was fixed.

If you find this decision to be in error, please reopen the issue.

from jsdav.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.