AndroidAnnotations listed by default

[mikepenz]

AndroidAnnotations listed by default

[mikepenz]

The problem with this version was that i merged a wrong contribution of androidannotations. which was marked as internal which means it always thought that it was included.

Fixed this issue with a version in 4.x

[mikepenz]

This is the specific commit fixing this issue:
4bf7969

[mikepenz]

So created a new branch with the v3.x.x versions and fixed this issue. I've also added all new libraries from the current v4.x.x version and the cc30 license.

1d40c91

The changes are under com.tundem.aboutlibraries:3.0.5

[johnjohndoe]

Good intention but please do not squash commits together that are no contextual related. The bugfix is one thing, project updates another, and library additions are worth a separate commit too. The commit 1d40c91 is way to unreadable.

Also you updated the target SDK in this commit which hinders people from using the library with their v.20 project. I suggest you maintain a v.3.x.x branch which stays with the v.20 and gets all bugfixes which are applied to the master branch. Additional features such as library additions are a nice benefit but not necessary.

[mikepenz]

@johnjohndoe yeah you are right. my only intention was to get it working for those people again.

But you are right i updated the target version. really forgot about it.

Just thought i will add them so people on previous versions will also get those updates.

A different question. You've done pretty much already for this project. Are you interested in getting a contributor?

[johnjohndoe]

Please feel free to rewrite the commit and divide it and force push the branch. I prefer a readable history over a squashed commit.
With regards to contributions I am fine with pull requests - but thank you for the invitation.

[mikepenz]

@johnjohndoe thanks again. I've rewritten this commit and split it up. i also uploaded a new version to maven with buildSdkTools 20 instead of 21. i had to update the buildTools to be able to upload the lib. Should be fine now :)

[johnjohndoe]

Much better :) The last two commits are not 100% clean - the separate contexts are:

• Update Gradle plug-in to v.0.14.2. and deprecated configuration such as runProguard.
• Update build tools to v.21.1.1.
• Prepare new release v.3.0.5.

[mikepenz]

Thanks :)

Ok will keep it in mind for future updates :D i think it's ok for today.

[johnjohndoe]

Jeap. :)

[johnjohndoe]

The tag for v.3.0.5 is missing.

[mikepenz]

For me its shown in the releases view:
https://github.com/mikepenz/AboutLibraries/releases/tag/v3.0.5

[johnjohndoe]

@mikepenz OH. It sits at the wrong commit - it looks like it is the "squashed" commit that was there earlier. You have to delete and add it again to 0b73d68. You can best see it via gitk --all.